Merge pull request #153 from plivo/fix-api-response

Adding api id to list conferences API
This commit is contained in:
nixonsam 2020-04-28 12:24:10 +05:30 committed by GitHub
commit c3e6d1dc6a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 4 deletions

View file

@ -1,5 +1,8 @@
# Change Log
## [4.5.2](https://github.com/plivo/plivo-node/releases/tag/v4.5.2)(2020-04-28)
- Fix List Conferences API response.
## [4.5.1](https://github.com/plivo/plivo-node/releases/tag/v4.5.1)(2020-04-13)
- Fix Cannot read property 'hasOwnProperty' of undefined error.

View file

@ -326,7 +326,7 @@ export class ConferenceInterface extends PlivoResourceInterface {
name: conference
}));
});
resolve(conferences);
resolve(response.body);
})
.catch(error => {
reject(error);

View file

@ -1,6 +1,6 @@
{
"name": "plivo",
"version": "4.5.1",
"version": "4.5.2",
"description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML",
"homepage": "https://github.com/plivo/plivo-node",
"files": [

View file

@ -16,8 +16,8 @@ describe('Conference', function () {
it('should get all conferences', function () {
return client.conferences.list()
.then(function(conferences) {
assert.equal(conferences[0].name, 'My Conf Room' )
.then(function(response) {
assert.equal(response.conferences[0], 'My Conf Room' )
})
});