From 182c72eaf83700648f55d92540fb4faef8639251 Mon Sep 17 00:00:00 2001 From: bhuvanvenkat-plivo Date: Mon, 27 Apr 2020 13:03:52 +0530 Subject: [PATCH 1/2] Adding api id to list conferences API --- lib/resources/conferences.js | 2 +- test/conferences.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/resources/conferences.js b/lib/resources/conferences.js index 9730943..1e506f3 100644 --- a/lib/resources/conferences.js +++ b/lib/resources/conferences.js @@ -326,7 +326,7 @@ export class ConferenceInterface extends PlivoResourceInterface { name: conference })); }); - resolve(conferences); + resolve(response.body); }) .catch(error => { reject(error); diff --git a/test/conferences.js b/test/conferences.js index 6541f41..5282930 100644 --- a/test/conferences.js +++ b/test/conferences.js @@ -16,8 +16,8 @@ describe('Conference', function () { it('should get all conferences', function () { return client.conferences.list() - .then(function(conferences) { - assert.equal(conferences[0].name, 'My Conf Room' ) + .then(function(response) { + assert.equal(response.conferences[0], 'My Conf Room' ) }) }); From f7264e7aae85a173845662905abedd0d7a78292d Mon Sep 17 00:00:00 2001 From: nixonsamuel Date: Tue, 28 Apr 2020 12:23:13 +0530 Subject: [PATCH 2/2] bump version to 4.5.2 --- CHANGELOG.md | 3 +++ package.json | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8295bb3..b60c29d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ # Change Log +## [4.5.2](https://github.com/plivo/plivo-node/releases/tag/v4.5.2)(2020-04-28) +- Fix List Conferences API response. + ## [4.5.1](https://github.com/plivo/plivo-node/releases/tag/v4.5.1)(2020-04-13) - Fix Cannot read property 'hasOwnProperty' of undefined error. diff --git a/package.json b/package.json index 6e7263f..d4767da 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "plivo", - "version": "4.5.1", + "version": "4.5.2", "description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML", "homepage": "https://github.com/plivo/plivo-node", "files": [