[PR #51] [MERGED] Add shouldRollback option to DataProxy #51

Closed
opened 2026-05-23 08:37:29 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/appy-one/acebase-core/pull/51
Author: @appy-one
Created: 3/27/2025
Status: Merged
Merged: 3/28/2025
Merged by: @appy-one

Base: masterHead: feature/allow-preventing-rolling-back-failed-updates


📝 Commits (2)

  • 539ba78 Add beforeRollback option to DataProxy that can prevent rolling back a failed update attempt. The callback function can decide to cancel the rollback. This is useful if a client with local cache database is used and the server encountered a server/processing error: a pending mutation will have been saved and retried later.
  • cb81ac3 Rename to shouldRollback, allow async, correct documentation that only returning false will prevent rollback

📊 Changes

1 file changed (+19 additions, -5 deletions)

View changed files

📝 src/data-proxy.ts (+19 -5)

📄 Description

Add shouldRollback option to DataProxy that can prevent rolling back a failed update attempt. The callback function can decide to cancel the rollback. This is useful if a client with local cache database is used and the server encountered a server/processing error: a pending mutation will have been saved and retried later.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/appy-one/acebase-core/pull/51 **Author:** [@appy-one](https://github.com/appy-one) **Created:** 3/27/2025 **Status:** ✅ Merged **Merged:** 3/28/2025 **Merged by:** [@appy-one](https://github.com/appy-one) **Base:** `master` ← **Head:** `feature/allow-preventing-rolling-back-failed-updates` --- ### 📝 Commits (2) - [`539ba78`](https://github.com/appy-one/acebase-core/commit/539ba78b7456f5e35f0138c842a8c40f53dd7cdc) Add `beforeRollback` option to `DataProxy` that can prevent rolling back a failed update attempt. The callback function can decide to cancel the rollback. This is useful if a client with local cache database is used and the server encountered a server/processing error: a pending mutation will have been saved and retried later. - [`cb81ac3`](https://github.com/appy-one/acebase-core/commit/cb81ac3ea376c808c6f82ecd2ad83d046197bdd3) Rename to `shouldRollback`, allow async, correct documentation that only returning `false` will prevent rollback ### 📊 Changes **1 file changed** (+19 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/data-proxy.ts` (+19 -5) </details> ### 📄 Description Add `shouldRollback` option to `DataProxy` that can prevent rolling back a failed update attempt. The callback function can decide to cancel the rollback. This is useful if a client with local cache database is used and the server encountered a server/processing error: a pending mutation will have been saved and retried later. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-23 08:37:29 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/acebase-core#51
No description provided.