github-starred/acebase-core

Fork 0

mirror of https://github.com/appy-one/acebase-core.git synced 2026-05-24 22:01:23 -06:00

[PR #31] [MERGED] Fix stopping LiveDataProxy `onChange` subscriptions #31

New issue

Closed

opened 2026-05-23 08:37:03 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-23 08:37:03 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/appy-one/acebase-core/pull/31
Author: @appy-one
Created: 1/5/2023
Status: ✅ Merged
Merged: 1/5/2023
Merged by: @appy-one

Base: master ← Head: fix/live-data-proxy-issue-30

📝 Commits (2)

d0c2ead remove erroneous .off('mutations')
d742b76 fix comment indentations

📊 Changes

1 file changed (+5 additions, -5 deletions)

View changed files

📝 src/data-proxy.ts (+5 -5)

📄 Description

Remove .off('mutations') call that clears all current subscriptions instead of just the one being stopped
Closes #30

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/appy-one/acebase-core/pull/31 **Author:** [@appy-one](https://github.com/appy-one) **Created:** 1/5/2023 **Status:** ✅ Merged **Merged:** 1/5/2023 **Merged by:** [@appy-one](https://github.com/appy-one) **Base:** `master` ← **Head:** `fix/live-data-proxy-issue-30` --- ### 📝 Commits (2) - [`d0c2ead`](https://github.com/appy-one/acebase-core/commit/d0c2eadedcd978dea033628c87e89cc63ebece1f) remove erroneous `.off('mutations')` - [`d742b76`](https://github.com/appy-one/acebase-core/commit/d742b76bfd4ffefcdaa48db3816bd3ef1c2b5097) fix comment indentations ### 📊 Changes **1 file changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/data-proxy.ts` (+5 -5) </details> ### 📄 Description Remove `.off('mutations')` call that clears all current subscriptions instead of just the one being stopped Closes #30 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-23 08:37:03 -06:00

closed this issue
added the
pull-request
label

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/acebase-core#31

No description provided.

Rows
Columns

[PR #31] [MERGED] Fix stopping LiveDataProxy onChange subscriptions #31

📋 Pull Request Information

📝 Commits (2)

📊 Changes

📄 Description

[PR #31] [MERGED] Fix stopping LiveDataProxy `onChange` subscriptions #31