github/plivo-node
2
0
Fork 0
mirror of https://github.com/donl/plivo-node.git synced 2026-05-31 22:07:36 -06:00
Code Issues Projects Packages Wiki Activity Actions

Merge pull request #107 from patelravi/message_list_test

Browse source 
Message list test
This commit is contained in:
nixonsam 2019-02-12 11:33:47 +05:30 • committed by GitHub
commit b8d2b11530
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
gulpfile.js
View file

@ -43,6 +43,8 @@ gulp.task('pre-test', function () {
gulp.task('test', ['pre-test'], function (cb) {
var mochaErr;
console.log('Running tests with node version', process.version);
gulp.src('test/**/*.js')
.pipe(plumber())
.pipe(mocha({ reporter: 'spec' }))
@ -62,6 +64,7 @@ gulp.task('watch', function () {
gulp.task('coveralls', ['test'], function () {
if (!process.env.CI) {
console.log('ignoring coveralls report generation.');
return;
}

14
lib/rest/utils.js
View file

@ -22,7 +22,17 @@ export function camelCaseRequestWrapper(requestFunc) {
return (method, action, params) => {
params = recursivelyRenameObject(params, function (value, key) {
if(typeof key !== 'string') return key;
if (typeof key !== 'string') return key;
// Snake Case logic has issue, it replaces double underscores with single
// So dont run snake case logic for following params
let skipParamsFromSnakeCasing = [
'message_time__lt', 'message_time__lte',
'message_time__gt', 'message_time__gte',
]
if (skipParamsFromSnakeCasing.indexOf(key) >= 0) {
return key;
}
return _snakeCase(key)
.replace('_less_than', '__lt')
@ -35,7 +45,7 @@ export function camelCaseRequestWrapper(requestFunc) {
return requestFunc(method, action, params).then(res => {
res.body = recursivelyRenameObject(res.body, function (value, key) {
if(typeof key !== 'string') return key;
if (typeof key !== 'string') return key;
return _camelCase(key);
});

2
package.json
View file

@ -66,4 +66,4 @@
"uri-parser": "^1.0.0",
"utf8": "^2.1.2"
}
}
}