From e60d5d927ab0f48ccea580adc78819a7af11a1f7 Mon Sep 17 00:00:00 2001 From: huzaif-plivo Date: Wed, 11 Aug 2021 16:52:45 +0530 Subject: [PATCH 01/13] test powerpack --- lib/resources/powerpacks.js | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/resources/powerpacks.js b/lib/resources/powerpacks.js index 9e96fed..ff69586 100644 --- a/lib/resources/powerpacks.js +++ b/lib/resources/powerpacks.js @@ -457,7 +457,6 @@ export class Powerpack extends PlivoResource { * @param {string} [params.sticky_sender] * @param {string} [params.local_connect] * @param {object} [params.number_priority] - * @promise {object} return {@link Powerpack} object * @fail {Error} return Error */ From 470433a784b57ecef45d449ba3c21c2a5695dd2b Mon Sep 17 00:00:00 2001 From: huzaif-plivo Date: Wed, 11 Aug 2021 17:00:29 +0530 Subject: [PATCH 02/13] test powerpack --- lib/resources/powerpacks.js | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/lib/resources/powerpacks.js b/lib/resources/powerpacks.js index ff69586..13eba76 100644 --- a/lib/resources/powerpacks.js +++ b/lib/resources/powerpacks.js @@ -1,6 +1,7 @@ import * as _ from 'lodash'; import { + PlivoGenericResponse, PlivoResource, PlivoResourceInterface } from '../base'; @@ -695,8 +696,30 @@ export class PowerpackInterface extends PlivoResourceInterface { * @promise {object} return {@link Powerpack} object * @fail {Error} return Error */ - get(uuid) { - return super.get(uuid); + get(uuid) { + let errors = validate([{ + field: 'uuid', + value: uuid, + validators: ['isRequired'] + }]); + + if (errors) { + return errors; + } + + let client = this[clientKey]; + return new Promise((resolve, reject) => { + if (action !== '' && !uuid) { + reject(new Error(this[idKey] + ' must be set')); + } + client('GET', action + (uuid ? uuid + '/' : '')) + .then(response => { + resolve(new PlivoGenericResponse(response.body, client)); + }) + .catch(error => { + reject(error); + }); + }); } /** * create Powerpack From aa8e032f4b969333cebf1921dcc139407c95a1ca Mon Sep 17 00:00:00 2001 From: huzaif-plivo Date: Wed, 11 Aug 2021 17:06:47 +0530 Subject: [PATCH 03/13] test powerpack --- lib/resources/powerpacks.js | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/lib/resources/powerpacks.js b/lib/resources/powerpacks.js index 13eba76..0b39203 100644 --- a/lib/resources/powerpacks.js +++ b/lib/resources/powerpacks.js @@ -41,6 +41,22 @@ export class CreatePowerpackResponse { } } +export class RetrievePowerpack { + constructor(params) { + params = params || {}; + this.apiId = params.apiId; + this.applicationId = params.applicationId; + this.applicationType = params.applicationType; + this.createdOn = params.createdOn; + this.localConnect = params.localConnect; + this.name = params.name; + this.numberPool = params.numberPool; + this.numberPriority = params.numberPriority; + this.stickySender = params.stickySender; + this.uuid = params.uuid; + } +} + export class UpdatePowerpackResponse { constructor(params) { params = params || {}; @@ -721,6 +737,7 @@ export class PowerpackInterface extends PlivoResourceInterface { }); }); } + /** * create Powerpack * @method From 0be019cda029bf6385c85c53046fccac5a828521 Mon Sep 17 00:00:00 2001 From: huzaif-plivo Date: Wed, 11 Aug 2021 17:14:34 +0530 Subject: [PATCH 04/13] test powerpack --- lib/resources/powerpacks.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/resources/powerpacks.js b/lib/resources/powerpacks.js index 0b39203..5e0b0aa 100644 --- a/lib/resources/powerpacks.js +++ b/lib/resources/powerpacks.js @@ -730,7 +730,7 @@ export class PowerpackInterface extends PlivoResourceInterface { } client('GET', action + (uuid ? uuid + '/' : '')) .then(response => { - resolve(new PlivoGenericResponse(response.body, client)); + resolve(new RetrievePowerpack(response.body, client)); }) .catch(error => { reject(error); From fbdc4d6c6f12b22041c22cc3d92aecb913be5f08 Mon Sep 17 00:00:00 2001 From: huzaif-plivo Date: Wed, 11 Aug 2021 17:17:12 +0530 Subject: [PATCH 05/13] test powerpack --- lib/resources/powerpacks.js | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/resources/powerpacks.js b/lib/resources/powerpacks.js index 5e0b0aa..26c1d2c 100644 --- a/lib/resources/powerpacks.js +++ b/lib/resources/powerpacks.js @@ -1,7 +1,6 @@ import * as _ from 'lodash'; import { - PlivoGenericResponse, PlivoResource, PlivoResourceInterface } from '../base'; From f6648e4b766be3decd2a7ecf5a93fb804c48f831 Mon Sep 17 00:00:00 2001 From: huzaif-plivo Date: Wed, 11 Aug 2021 17:30:41 +0530 Subject: [PATCH 06/13] test powerpack --- lib/resources/powerpacks.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/resources/powerpacks.js b/lib/resources/powerpacks.js index 26c1d2c..a09f022 100644 --- a/lib/resources/powerpacks.js +++ b/lib/resources/powerpacks.js @@ -729,7 +729,7 @@ export class PowerpackInterface extends PlivoResourceInterface { } client('GET', action + (uuid ? uuid + '/' : '')) .then(response => { - resolve(new RetrievePowerpack(response.body, client)); + resolve(new PlivoGenericResponse(response.body, client)); }) .catch(error => { reject(error); From b2c76e00d7df2f25a5fd4e14dfa00c78ab5223a9 Mon Sep 17 00:00:00 2001 From: huzaif-plivo Date: Wed, 11 Aug 2021 17:35:15 +0530 Subject: [PATCH 07/13] test powerpack --- lib/resources/powerpacks.js | 43 ++----------------------------------- 1 file changed, 2 insertions(+), 41 deletions(-) diff --git a/lib/resources/powerpacks.js b/lib/resources/powerpacks.js index a09f022..ff69586 100644 --- a/lib/resources/powerpacks.js +++ b/lib/resources/powerpacks.js @@ -40,22 +40,6 @@ export class CreatePowerpackResponse { } } -export class RetrievePowerpack { - constructor(params) { - params = params || {}; - this.apiId = params.apiId; - this.applicationId = params.applicationId; - this.applicationType = params.applicationType; - this.createdOn = params.createdOn; - this.localConnect = params.localConnect; - this.name = params.name; - this.numberPool = params.numberPool; - this.numberPriority = params.numberPriority; - this.stickySender = params.stickySender; - this.uuid = params.uuid; - } -} - export class UpdatePowerpackResponse { constructor(params) { params = params || {}; @@ -711,32 +695,9 @@ export class PowerpackInterface extends PlivoResourceInterface { * @promise {object} return {@link Powerpack} object * @fail {Error} return Error */ - get(uuid) { - let errors = validate([{ - field: 'uuid', - value: uuid, - validators: ['isRequired'] - }]); - - if (errors) { - return errors; - } - - let client = this[clientKey]; - return new Promise((resolve, reject) => { - if (action !== '' && !uuid) { - reject(new Error(this[idKey] + ' must be set')); - } - client('GET', action + (uuid ? uuid + '/' : '')) - .then(response => { - resolve(new PlivoGenericResponse(response.body, client)); - }) - .catch(error => { - reject(error); - }); - }); + get(uuid) { + return super.get(uuid); } - /** * create Powerpack * @method From c81dfc7e26a904b9d9206e828608e5732267d2ec Mon Sep 17 00:00:00 2001 From: Mohammed Huzaif Date: Wed, 11 Aug 2021 18:23:20 +0530 Subject: [PATCH 08/13] Update powerpacks.js --- lib/resources/powerpacks.js | 29 ++++++++++++++++++++++++++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/lib/resources/powerpacks.js b/lib/resources/powerpacks.js index ff69586..014d1af 100644 --- a/lib/resources/powerpacks.js +++ b/lib/resources/powerpacks.js @@ -1,6 +1,7 @@ import * as _ from 'lodash'; import { + PlivoGenericResponse, PlivoResource, PlivoResourceInterface } from '../base'; @@ -695,8 +696,30 @@ export class PowerpackInterface extends PlivoResourceInterface { * @promise {object} return {@link Powerpack} object * @fail {Error} return Error */ - get(uuid) { - return super.get(uuid); + get(uuid) { + let errors = validate([{ + field: 'uuid', + value: uuid, + validators: ['isRequired'] + }]); + + if (errors) { + return errors; + } + + let client = this[clientKey]; + return new Promise((resolve, reject) => { + if (action !== '' && !uuid) { + reject(new Error(this[idKey] + ' must be set')); + } + client('GET', action + (uuid ? uuid + '/' : '')) + .then(response => { + resolve(new PlivoGenericResponse(response.body, client)); + }) + .catch(error => { + reject(error); + }); + }); } /** * create Powerpack @@ -776,4 +799,4 @@ export class PowerpackInterface extends PlivoResourceInterface { list(params) { return super.list(params); } -} \ No newline at end of file +} From c7f3b24f778e8b72600f6942553e7bbcca12e19d Mon Sep 17 00:00:00 2001 From: Mohammed Huzaif Date: Wed, 11 Aug 2021 18:30:06 +0530 Subject: [PATCH 09/13] Update powerpacks.js --- lib/resources/powerpacks.js | 24 +----------------------- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/lib/resources/powerpacks.js b/lib/resources/powerpacks.js index 014d1af..df0ddf5 100644 --- a/lib/resources/powerpacks.js +++ b/lib/resources/powerpacks.js @@ -697,29 +697,7 @@ export class PowerpackInterface extends PlivoResourceInterface { * @fail {Error} return Error */ get(uuid) { - let errors = validate([{ - field: 'uuid', - value: uuid, - validators: ['isRequired'] - }]); - - if (errors) { - return errors; - } - - let client = this[clientKey]; - return new Promise((resolve, reject) => { - if (action !== '' && !uuid) { - reject(new Error(this[idKey] + ' must be set')); - } - client('GET', action + (uuid ? uuid + '/' : '')) - .then(response => { - resolve(new PlivoGenericResponse(response.body, client)); - }) - .catch(error => { - reject(error); - }); - }); + return super.get(uuid); } /** * create Powerpack From 9d045519cee26fef99e3285b14a20062f8ac2647 Mon Sep 17 00:00:00 2001 From: Mohammed Huzaif Date: Wed, 11 Aug 2021 18:30:24 +0530 Subject: [PATCH 10/13] Update powerpacks.js --- lib/resources/powerpacks.js | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/resources/powerpacks.js b/lib/resources/powerpacks.js index df0ddf5..2df1d4c 100644 --- a/lib/resources/powerpacks.js +++ b/lib/resources/powerpacks.js @@ -1,7 +1,6 @@ import * as _ from 'lodash'; import { - PlivoGenericResponse, PlivoResource, PlivoResourceInterface } from '../base'; From fe03992b8580debaded823bd28031b7247924de2 Mon Sep 17 00:00:00 2001 From: huzaif-plivo Date: Thu, 12 Aug 2021 13:58:17 +0530 Subject: [PATCH 11/13] bump version --- CHANGELOG.md | 3 +++ package.json | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d7cc6b8..d10477d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ # Change Log +## [v4.22.0](https://github.com/plivo/plivo-node/tree/v4.22.0) (2021-08-12) +- Fix add numbers to a powerpack by reverting retrievable object responses support for [Retrieve a Power pack API](https://www.plivo.com/docs/sms/api/powerpack#retrieve-a-powerpack). + ## [v4.21.0](https://github.com/plivo/plivo-node/tree/v4.21.0) (2021-08-05) - Fixed a Typescript warning about base interpretation. - Add retrievable object responses support for [Retrieve a Power pack API](https://www.plivo.com/docs/sms/api/powerpack#retrieve-a-powerpack). diff --git a/package.json b/package.json index a471bda..e76ea7e 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "plivo", - "version": "4.21.0", + "version": "4.22.0", "description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML", "homepage": "https://github.com/plivo/plivo-node", "files": [ From b306e6d78d3edf94bd3262299ad5d6195f253c7c Mon Sep 17 00:00:00 2001 From: huzaif-plivo Date: Thu, 12 Aug 2021 15:22:03 +0530 Subject: [PATCH 12/13] bump version --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d10477d..1c9d6fa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,7 @@ # Change Log ## [v4.22.0](https://github.com/plivo/plivo-node/tree/v4.22.0) (2021-08-12) -- Fix add numbers to a powerpack by reverting retrievable object responses support for [Retrieve a Power pack API](https://www.plivo.com/docs/sms/api/powerpack#retrieve-a-powerpack). +- Fix [add numbers to a powerpack](https://www.plivo.com/docs/sms/api/numberpool/#add-a-number) API by reverting retrievable object responses support for [Retrieve a Power pack API](https://www.plivo.com/docs/sms/api/powerpack#retrieve-a-powerpack). ## [v4.21.0](https://github.com/plivo/plivo-node/tree/v4.21.0) (2021-08-05) - Fixed a Typescript warning about base interpretation. From 9b22f77375acc5a3677d76159caff76f4aa2e459 Mon Sep 17 00:00:00 2001 From: huzaif-plivo Date: Mon, 16 Aug 2021 19:34:38 +0530 Subject: [PATCH 13/13] update changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1c9d6fa..bf298a9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # Change Log -## [v4.22.0](https://github.com/plivo/plivo-node/tree/v4.22.0) (2021-08-12) +## [v4.22.0](https://github.com/plivo/plivo-node/tree/v4.22.0) (2021-08-17) - Fix [add numbers to a powerpack](https://www.plivo.com/docs/sms/api/numberpool/#add-a-number) API by reverting retrievable object responses support for [Retrieve a Power pack API](https://www.plivo.com/docs/sms/api/powerpack#retrieve-a-powerpack). ## [v4.21.0](https://github.com/plivo/plivo-node/tree/v4.21.0) (2021-08-05)