From f5ac22de50f26222e9b4c309313b4ffddae80cbf Mon Sep 17 00:00:00 2001 From: narayana Date: Mon, 18 Apr 2022 09:49:20 +0530 Subject: [PATCH 1/6] callback support for brand, campaign and link number api --- lib/resources/brand.js | 3 +-- lib/resources/campaign.js | 6 ++---- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/resources/brand.js b/lib/resources/brand.js index 7e93b23..7c7b9db 100644 --- a/lib/resources/brand.js +++ b/lib/resources/brand.js @@ -87,8 +87,7 @@ export class BrandCreationResponse { * @promise {object} return {@link PlivoGenericResponse} object * @fail {Error} return Error */ - create(brand_alias,profile_uuid,brand_type,secondary_vetting) { - let params = {}; + create(brand_alias,profile_uuid,brand_type,secondary_vetting, params = {}) { params.brand_alias=brand_alias; params.profile_uuid=profile_uuid; params.brand_type=brand_type; diff --git a/lib/resources/campaign.js b/lib/resources/campaign.js index 675325d..b4110e1 100644 --- a/lib/resources/campaign.js +++ b/lib/resources/campaign.js @@ -120,8 +120,7 @@ export class LinkUnlinkNumberResponse { * @promise {object} return {@link PlivoGenericResponse} object * @fail {Error} return Error */ - create(brand_id,campaign_alias,vertical,usecase,sub_usecases,description,embedded_link,embedded_phone,age_gated,direct_lending,subscriber_optin,subscriber_optout,subscriber_help,sample1,sample2) { - let params = {} + create(brand_id,campaign_alias,vertical,usecase,sub_usecases,description,embedded_link,embedded_phone,age_gated,direct_lending,subscriber_optin,subscriber_optout,subscriber_help,sample1,sample2, params = {}) { params.brand_id=brand_id; params.campaign_alias=campaign_alias; params.vertical=vertical; @@ -182,8 +181,7 @@ export class LinkUnlinkNumberResponse { * @promise {object} return {@link Campaign} object * @fail {Error} return Error */ - linkNumber(campaignID, numbers) { - let params = {} + linkNumber(campaignID, numbers, params = {}) { params.numbers=numbers; let client = this[clientKey]; return new Promise((resolve, reject) => { From aebd111fb67b300d17b2e4afd1b276a9b1b5ffb8 Mon Sep 17 00:00:00 2001 From: narayana Date: Mon, 18 Apr 2022 09:51:37 +0530 Subject: [PATCH 2/6] callback support for brand, campaign and link number api --- CHANGELOG.md | 4 ++++ package.json | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e13ee89..0ab81bc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Change Log +## [v4.30.1](https://github.com/plivo/plivo-node/tree/v4.30.1) (2022-04-18) +**Feature - 10DLC API callback** +- Added callback support for campaign, brand, link number request. + ## [v4.30.0](https://github.com/plivo/plivo-node/tree/v4.30.0) (2022-04-14) **Features - Profile Api** - Profile api added for 10dlc support diff --git a/package.json b/package.json index b12d46c..0487b53 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "plivo", - "version": "4.30.0", + "version": "4.30.1", "description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML", "homepage": "https://github.com/plivo/plivo-node", "files": [ From 45f1a2860b0ef081878ec2c8bd233089b55ade78 Mon Sep 17 00:00:00 2001 From: narayana Date: Mon, 25 Apr 2022 16:09:25 +0530 Subject: [PATCH 3/6] number unlink --- lib/resources/campaign.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/resources/campaign.js b/lib/resources/campaign.js index b4110e1..635e507 100644 --- a/lib/resources/campaign.js +++ b/lib/resources/campaign.js @@ -203,8 +203,7 @@ export class LinkUnlinkNumberResponse { * @promise {object} return {@link Campaign} object * @fail {Error} return Error */ - unlinkNumber(campaignID, number) { - let params = {} + unlinkNumber(campaignID, number, params = {}) { let client = this[clientKey]; return new Promise((resolve, reject) => { client('DELETE', action+campaignID+'/Number/'+number+'/', params) From 4edc359bea87cf283927e5caffa6a019d8cee95c Mon Sep 17 00:00:00 2001 From: Mohammed Huzaif Date: Wed, 27 Apr 2022 16:59:39 +0530 Subject: [PATCH 4/6] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0ab81bc..435e395 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # Change Log -## [v4.30.1](https://github.com/plivo/plivo-node/tree/v4.30.1) (2022-04-18) +## [v4.31.0](https://github.com/plivo/plivo-node/tree/v4.30.1) (2022-04-27) **Feature - 10DLC API callback** - Added callback support for campaign, brand, link number request. From 6d376773b9228bb9d6d0dabb96ea154b5fe6e211 Mon Sep 17 00:00:00 2001 From: Mohammed Huzaif Date: Wed, 27 Apr 2022 17:00:08 +0530 Subject: [PATCH 5/6] Update package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 0487b53..b407d4e 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "plivo", - "version": "4.30.1", + "version": "4.31.0", "description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML", "homepage": "https://github.com/plivo/plivo-node", "files": [ From 194cdc5d00eda0ffdb663ceff034e2348c05f013 Mon Sep 17 00:00:00 2001 From: Mohammed Huzaif Date: Wed, 27 Apr 2022 17:07:08 +0530 Subject: [PATCH 6/6] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 435e395..12ee355 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # Change Log -## [v4.31.0](https://github.com/plivo/plivo-node/tree/v4.30.1) (2022-04-27) +## [v4.31.0](https://github.com/plivo/plivo-node/tree/v4.31.0) (2022-04-27) **Feature - 10DLC API callback** - Added callback support for campaign, brand, link number request.