From 6de3ef035eb84659012978a3e71d7a96d05d9ce4 Mon Sep 17 00:00:00 2001 From: narayana Date: Mon, 12 Sep 2022 14:26:23 +0530 Subject: [PATCH 1/5] adding more attributes to request --- CHANGELOG.md | 4 ++++ lib/resources/campaign.js | 8 +++++++- package.json | 2 +- test/campaign.js | 2 +- 4 files changed, 13 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7294f26..0e91af9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Change Log +## [v4.34.1](https://github.com/plivo/plivo-go/tree/v4.34.1) (2022-09-12) +**10DLC campaign creation** +- Adding more attributes to campaign creation request. + ## [v4.34.0](https://github.com/plivo/plivo-go/tree/v4.34.0) (2022-08-07) **Feature - Token Creation** - `JWT Token Creation API` added API to create a new JWT token. diff --git a/lib/resources/campaign.js b/lib/resources/campaign.js index c1517c4..2caccef 100644 --- a/lib/resources/campaign.js +++ b/lib/resources/campaign.js @@ -118,10 +118,13 @@ export class LinkUnlinkNumberResponse { * @param {boolean} affiliate_marketing * @param {string} sample1 * @param {string} sample2 + * @param {message_flow} message_flow + * @param {help_message} help_message + * @param {optout_message} optout_message * @promise {object} return {@link PlivoGenericResponse} object * @fail {Error} return Error */ - create(brand_id,campaign_alias,vertical,usecase,sub_usecases,description,embedded_link,embedded_phone,age_gated,direct_lending,subscriber_optin,subscriber_optout,subscriber_help,affiliate_marketing,sample1,sample2, params = {}) { + create(brand_id,campaign_alias,vertical,usecase,sub_usecases,description,embedded_link,embedded_phone,age_gated,direct_lending,subscriber_optin,subscriber_optout,subscriber_help,affiliate_marketing,sample1,sample2, message_flow,help_message,optout_message,params = {}) { params.brand_id=brand_id; params.campaign_alias=campaign_alias; params.vertical=vertical; @@ -138,6 +141,9 @@ export class LinkUnlinkNumberResponse { params.affiliate_marketing=affiliate_marketing; params.sample1=sample1; params.sample2=sample2; + params.message_flow=message_flow; + params.help_message=help_message; + params.optout_message=optout_message; let client = this[clientKey]; return new Promise((resolve, reject) => { client('POST', action, params) diff --git a/package.json b/package.json index eae67d2..06c049d 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "plivo", - "version": "4.34.0", + "version": "4.34.1", "description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML", "homepage": "https://github.com/plivo/plivo-node", "files": [ diff --git a/test/campaign.js b/test/campaign.js index 9cb53a8..2901774 100644 --- a/test/campaign.js +++ b/test/campaign.js @@ -28,7 +28,7 @@ import { return client.campaign.create("B8OD95Z","campaign name sssample","INSURANCE","MIXED",[ "CUSTOMER_CARE", "2FA" - ],"sample description text",false,false,false,false,true,true,true,"sample1","sample2") + ],"sample description text should 40 character",false,false,false,false,true,true,true,"sample1 should be 20 minimum character","sample2 should be 20 minimum character", "message_flow should be 40 minimum character", "help_message should be 20 minimum character", "optout_message should be 20 minimum character") .then(function (campaign) { assert.equal(campaign.campaignId, 'CFSOBZQ') }) From 201e21b91f27dc388d235ce9cc8d542a707e6933 Mon Sep 17 00:00:00 2001 From: narayana Date: Mon, 12 Sep 2022 14:43:16 +0530 Subject: [PATCH 2/5] test --- .github/workflows/unitTests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/unitTests.yml b/.github/workflows/unitTests.yml index 3532ff1..4598295 100644 --- a/.github/workflows/unitTests.yml +++ b/.github/workflows/unitTests.yml @@ -22,7 +22,7 @@ jobs: with: node-version: ${{ matrix.node-version }} - run: npm install request - - run: npm install + - run: npm cache --force clean && npm install --force - run: npm test coverage: From 0c41ad24dbb31b8b8f48b5e0588edefb620499e7 Mon Sep 17 00:00:00 2001 From: narayana Date: Mon, 12 Sep 2022 14:48:53 +0530 Subject: [PATCH 3/5] test --- .github/workflows/unitTests.yml | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/unitTests.yml b/.github/workflows/unitTests.yml index 4598295..3532ff1 100644 --- a/.github/workflows/unitTests.yml +++ b/.github/workflows/unitTests.yml @@ -22,7 +22,7 @@ jobs: with: node-version: ${{ matrix.node-version }} - run: npm install request - - run: npm cache --force clean && npm install --force + - run: npm install - run: npm test coverage: diff --git a/package.json b/package.json index 06c049d..6cdd8b4 100644 --- a/package.json +++ b/package.json @@ -29,7 +29,7 @@ "eslint-plugin-babel": "^3.3.0", "eslint-plugin-flowtype": "^2.33.0", "flow-bin": "^0.47.0", - "gulp": "^4.0.2", + "gulp": "^4.0.9", "gulp-babel": "^6.1.2", "gulp-babel-istanbul": "^1.6.0", "gulp-eslint": "^3.0.1", From ff6caa6e9de79049a295b33711244d5fc24e59f2 Mon Sep 17 00:00:00 2001 From: narayana Date: Mon, 12 Sep 2022 14:50:26 +0530 Subject: [PATCH 4/5] version upgrade --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 6cdd8b4..06c049d 100644 --- a/package.json +++ b/package.json @@ -29,7 +29,7 @@ "eslint-plugin-babel": "^3.3.0", "eslint-plugin-flowtype": "^2.33.0", "flow-bin": "^0.47.0", - "gulp": "^4.0.9", + "gulp": "^4.0.2", "gulp-babel": "^6.1.2", "gulp-babel-istanbul": "^1.6.0", "gulp-eslint": "^3.0.1", From 50185d600506efddcf8cd4ceaff54d2cc4bb78e6 Mon Sep 17 00:00:00 2001 From: Narayana Shanbhog Date: Wed, 28 Sep 2022 20:08:17 +0530 Subject: [PATCH 5/5] date update --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0e91af9..400b417 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # Change Log -## [v4.34.1](https://github.com/plivo/plivo-go/tree/v4.34.1) (2022-09-12) +## [v4.34.1](https://github.com/plivo/plivo-go/tree/v4.34.1) (2022-09-28) **10DLC campaign creation** - Adding more attributes to campaign creation request.