mirror of
https://github.com/appy-one/acebase.git
synced 2026-05-25 06:02:14 -06:00
[GH-ISSUE #152] Using filter "in" with another filter on indexed bigInt does not return all values #83
Labels
No labels
IndexedDB
browser
bug
dependencies
documentation
duplicate
enhancement
feature request
indexes
indexes
invalid
pull-request
query
question
transaction logging
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/acebase#83
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Mitsichury on GitHub (Sep 11, 2022).
Original GitHub issue: https://github.com/appy-one/acebase/issues/152
Originally assigned to: @appy-one on GitHub.
Hi :)
I have trouble getting all values when using indexed BigInt value and combining query filters.
You can find a test that reproduce ths issue here : https://github.com/appy-one/acebase/pull/151/files
Hope it helps you, thank you for your amazing app :)
Best regards,
Mitsi.
@appy-one commented on GitHub (Sep 11, 2022):
Thanks Mitsi, after some digging, it appears to be a bug in the serialization of BigInts to binary format and/or vice versa. I'll have to fix that algorithm.
@appy-one commented on GitHub (Sep 12, 2022):
Fix has been published in acebase@1.24.2 and acebase-server@1.13.1
Note that you'll have to update the BigInt values in your db because some have been stored incorrectly!
@Mitsichury commented on GitHub (Sep 30, 2022):
Hi :)
Sorry for the late answer, I've updated to the last version 1.24.4, my tests still don't work if I create indexes on Bigint and I apply filters on it. But it works really great without indexes. I don't know why for now because your unit tests are green, I'll try to reproduce the issue.
Thank you for your amazing work :) !
@Mitsichury commented on GitHub (Sep 30, 2022):
I've found how to reproduce it !
I've modified a test to make it close to my usage : https://github.com/appy-one/acebase/pull/159/files
I don't know if it's a bug or a misusage from me.
Thank you,
Mitsi.
@appy-one commented on GitHub (Oct 3, 2022):
Thanks for your PR, I'm on it!
@appy-one commented on GitHub (Oct 3, 2022):
Hi Mitsi, I've fixed the issue and released new version v1.24.5
Note that the code in your PR does contain an async issue with
forEach, see my comments there.Let me know if it all works!
@Mitsichury commented on GitHub (Oct 4, 2022):
Hi @appy-one thank you for your review and your fix, it's working really good :D
Best regards,
Mitsi.