[GH-ISSUE #30] const issue in storage.js #29

New issue

Closed

opened 2026-05-23 08:26:35 -06:00 by gitea-mirror · 3 comments

gitea-mirror commented

2026-05-23 08:26:35 -06:00

Owner

Originally created by @clibu on GitHub (May 8, 2021).
Original GitHub issue: https://github.com/appy-one/acebase/issues/30

Originally assigned to: @appy-one on GitHub.

eslint shows the following error (amongst others) in storage.js

  1476:29  error    'ret' is constant                                      no-const-assign

This also prevents vite -> esbuild from building.

Line 1473 needs to change from const ret to let ret

eslint shows quite a few errors across multiple source files.

I also noticed that there are no test scripts specified in any package.json and only one test file path-info.spec.js
Does AceBase have a comprehensive test suite? If not is this planned.

Originally created by @clibu on GitHub (May 8, 2021). Original GitHub issue: https://github.com/appy-one/acebase/issues/30 Originally assigned to: @appy-one on GitHub. eslint shows the following error _(amongst others)_ in ``storage.js`` ```` 1476:29 error 'ret' is constant no-const-assign ```` This also prevents vite -> esbuild from building. Line 1473 needs to change from ``const ret`` to ``let ret`` eslint shows quite a few errors across multiple source files. I also noticed that there are no test scripts specified in any package.json and only one test file ``path-info.spec.js`` Does AceBase have a comprehensive test suite? If not is this planned.

gitea-mirror closed this issue

2026-05-23 08:26:36 -06:00

gitea-mirror commented

2026-05-23 08:26:40 -06:00

Author

Owner

@appy-one commented on GitHub (May 10, 2021):

Good catch. I've made quite a few changes to the code to enable clustering in nodejs environments, I've now also changed the line you referred to, hope to be able to commit them today. Regarding your test question - I have many test files locally that I run before publishing updates, but they are not suitable for automated testing atm

@appy-one commented on GitHub (May 10, 2021): Good catch. I've made quite a few changes to the code to enable clustering in nodejs environments, I've now also changed the line you referred to, hope to be able to commit them today. Regarding your test question - I have many test files locally that I run before publishing updates, but they are not suitable for automated testing atm

gitea-mirror commented

2026-05-23 08:26:41 -06:00

Author

Owner

@clibu commented on GitHub (May 13, 2021):

@appy-one Any progress on the new release yet, not that I'm in a hurry.

Re. the tests are you planning on automating and publishing them at some point?

@clibu commented on GitHub (May 13, 2021): @appy-one Any progress on the new release yet, not that I'm in a hurry. Re. the tests are you planning on automating and publishing them at some point?

gitea-mirror commented

2026-05-23 08:26:43 -06:00

Author

Owner

@appy-one commented on GitHub (May 19, 2021):

Fix published in v1.6.0. Don't know when I'll be working on automated tests

@appy-one commented on GitHub (May 19, 2021): Fix published in v1.6.0. Don't know when I'll be working on automated tests

gitea-mirror referenced this issue

2026-05-23 08:31:16 -06:00

[PR #29] [MERGED] Update README.md: browser example code typo fixed #120