[PR #259] [MERGED] Fix large index builds #189

New issue

Closed

opened 2026-05-23 08:32:55 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-23 08:32:55 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/appy-one/acebase/pull/259
Author: @appy-one
Created: 9/6/2025
Status: ✅ Merged
Merged: 9/16/2025
Merged by: @appy-one

Base: master ← Head: fix/large-index-builds

📝 Commits (5)

27ea13f Removed double property setting in constructor
f474787 Fix stack overflow when building a large index
49822b2 Refactor all .forEach calls to for .. of loops
6c67c95 Change JSDoc type to TypeScript
23812d5 Disable usage of socket IPC for tests, needs works

📊 Changes

4 files changed (+23 additions, -36 deletions)

View changed files

📝 src/btree/binary-tree-leaf-entry.ts (+0 -2)
📝 src/btree/binary-tree.ts (+6 -15)
📝 src/data-index/data-index.ts (+16 -18)
📝 src/test/tempdb.ts (+1 -1)

📄 Description

This fixes memory issues when building a large index. Looping the leaf values is now done without recursion to prevent memory heaping up in the callstack

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/appy-one/acebase/pull/259 **Author:** [@appy-one](https://github.com/appy-one) **Created:** 9/6/2025 **Status:** ✅ Merged **Merged:** 9/16/2025 **Merged by:** [@appy-one](https://github.com/appy-one) **Base:** `master` ← **Head:** `fix/large-index-builds` --- ### 📝 Commits (5) - [`27ea13f`](https://github.com/appy-one/acebase/commit/27ea13f06ec33ef9d0d1f6991fb99b5c4c16d473) Removed double property setting in constructor - [`f474787`](https://github.com/appy-one/acebase/commit/f474787296fc6ce0bbc5f35889b86cbc8dbc6403) Fix stack overflow when building a large index - [`49822b2`](https://github.com/appy-one/acebase/commit/49822b2cac42a739d10704248788c1a0c23513f3) Refactor all `.forEach` calls to `for .. of` loops - [`6c67c95`](https://github.com/appy-one/acebase/commit/6c67c9579b2e6cfef01a3e8bf77ac5b5a1b0c2bc) Change JSDoc type to TypeScript - [`23812d5`](https://github.com/appy-one/acebase/commit/23812d5b67460d74679ecaabb09ac64016c54b04) Disable usage of socket IPC for tests, needs works ### 📊 Changes **4 files changed** (+23 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `src/btree/binary-tree-leaf-entry.ts` (+0 -2) 📝 `src/btree/binary-tree.ts` (+6 -15) 📝 `src/data-index/data-index.ts` (+16 -18) 📝 `src/test/tempdb.ts` (+1 -1) </details> ### 📄 Description This fixes memory issues when building a large index. Looping the leaf values is now done without recursion to prevent memory heaping up in the callstack --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>