[PR #240] [MERGED] Fix issue #239 #184

New issue

Closed

opened 2026-05-23 08:32:47 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-23 08:32:47 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/appy-one/acebase/pull/240
Author: @appy-one
Created: 8/16/2023
Status: ✅ Merged
Merged: 8/16/2023
Merged by: @appy-one

Base: master ← Head: fix/issue-239

📝 Commits (4)

6d63cce Fix #239 deletion causing empty leaf issue
cae1cd6 Improve readability
fba5ede Add unit test
bae6386 Handle empty leafs

📊 Changes

2 files changed (+65 additions, -10 deletions)

View changed files

📝 src/btree/binary-tree.ts (+27 -10)
➕ src/storage/binary/test.spec.ts (+38 -0)

📄 Description

This fixes the issue described in #239, where adding children to an empty tree causes issues because the binary tree leaf was left behind empty. This code changes the delete behaviour to rebuild the tree after a leaf has become empty and its parent node will be left without child entries

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/appy-one/acebase/pull/240 **Author:** [@appy-one](https://github.com/appy-one) **Created:** 8/16/2023 **Status:** ✅ Merged **Merged:** 8/16/2023 **Merged by:** [@appy-one](https://github.com/appy-one) **Base:** `master` ← **Head:** `fix/issue-239` --- ### 📝 Commits (4) - [`6d63cce`](https://github.com/appy-one/acebase/commit/6d63cce2bcbf707dd21216840a3deb4d0417e80e) Fix #239 deletion causing empty leaf issue - [`cae1cd6`](https://github.com/appy-one/acebase/commit/cae1cd6f8b07db19badc15d302e6c7155640f16c) Improve readability - [`fba5ede`](https://github.com/appy-one/acebase/commit/fba5eded0eac48d679b25937fc82124c46328f1c) Add unit test - [`bae6386`](https://github.com/appy-one/acebase/commit/bae638645e2ec02c9e08b8db5b5b8738782b569a) Handle empty leafs ### 📊 Changes **2 files changed** (+65 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/btree/binary-tree.ts` (+27 -10) ➕ `src/storage/binary/test.spec.ts` (+38 -0) </details> ### 📄 Description This fixes the issue described in #239, where adding children to an empty tree causes issues because the binary tree leaf was left behind empty. This code changes the delete behaviour to rebuild the tree after a leaf has become empty and its parent node will be left without child entries --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>