[PR #223] [MERGED] Fix (invisible) tsc compile errors #176

New issue

Closed

opened 2026-05-23 08:32:38 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-23 08:32:38 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/appy-one/acebase/pull/223
Author: @appy-one
Created: 4/27/2023
Status: ✅ Merged
Merged: 4/30/2023
Merged by: @appy-one

Base: master ← Head: fix/tsc-compile-errors

📝 Commits (4)

8b260c2 Fix (invisible) tsc compile errors
a9cdca8 bump acebase-core to 1.26.2, typescript to 5.0.4
692958e disable skipLibCheck in tsconfig
596b072 Merge branch 'master' into fix/tsc-compile-errors

📊 Changes

11 files changed (+51 additions, -49 deletions)

View changed files

📝 package-lock.json (+15 -15)
📝 package.json (+2 -2)
📝 src/data-index/data-index.ts (+1 -1)
📝 src/data-index/geo-index.ts (+3 -3)
📝 src/node-info.ts (+2 -2)
📝 src/node-value-types.ts (+4 -2)
📝 src/storage/binary/index.ts (+10 -10)
📝 src/storage/custom/index.ts (+8 -8)
📝 src/storage/custom/local-storage/transaction.ts (+2 -2)
📝 src/storage/mssql/index.ts (+3 -3)
📝 src/storage/sqlite/index.ts (+1 -1)

📄 Description

When using AceBase in an external project using "skipLibraryCheck": false (default) in its tsconfig.json, it will yield compile errors that are not shown when compiling AceBase itself with tsc. Why there are no TypeScript errors should be investigated further. See #220

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/appy-one/acebase/pull/223 **Author:** [@appy-one](https://github.com/appy-one) **Created:** 4/27/2023 **Status:** ✅ Merged **Merged:** 4/30/2023 **Merged by:** [@appy-one](https://github.com/appy-one) **Base:** `master` ← **Head:** `fix/tsc-compile-errors` --- ### 📝 Commits (4) - [`8b260c2`](https://github.com/appy-one/acebase/commit/8b260c2e56e5910a6f76d822214c7fdc29bbaa6f) Fix (invisible) tsc compile errors - [`a9cdca8`](https://github.com/appy-one/acebase/commit/a9cdca83760ca1279e1681cdfe20964764c0c265) bump acebase-core to 1.26.2, typescript to 5.0.4 - [`692958e`](https://github.com/appy-one/acebase/commit/692958ef116d11d0c829f2d5ee350b31ad347a5e) disable `skipLibCheck` in tsconfig - [`596b072`](https://github.com/appy-one/acebase/commit/596b07208c7005f6beb40ffd6fa502684091074c) Merge branch 'master' into fix/tsc-compile-errors ### 📊 Changes **11 files changed** (+51 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `package-lock.json` (+15 -15) 📝 `package.json` (+2 -2) 📝 `src/data-index/data-index.ts` (+1 -1) 📝 `src/data-index/geo-index.ts` (+3 -3) 📝 `src/node-info.ts` (+2 -2) 📝 `src/node-value-types.ts` (+4 -2) 📝 `src/storage/binary/index.ts` (+10 -10) 📝 `src/storage/custom/index.ts` (+8 -8) 📝 `src/storage/custom/local-storage/transaction.ts` (+2 -2) 📝 `src/storage/mssql/index.ts` (+3 -3) 📝 `src/storage/sqlite/index.ts` (+1 -1) </details> ### 📄 Description When using AceBase in an external project using `"skipLibraryCheck": false` (default) in its _tsconfig.json_, it will yield compile errors that are not shown when compiling AceBase itself with `tsc`. Why there are no TypeScript errors should be investigated further. See #220 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>