[PR #224] [MERGED] Fix: Socket IPC preventing process exit #175

New issue

Closed

opened 2026-05-23 08:32:37 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-23 08:32:37 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/appy-one/acebase/pull/224
Author: @appy-one
Created: 5/1/2023
Status: ✅ Merged
Merged: 5/1/2023
Merged by: @appy-one

Base: master ← Head: fix/socket-ipc

📝 Commits (8)

8daa2b3 Work on socket IPC implementation:
a48341b Add config settings, no console logging
8cc685a use hash for socket/pipe if filePath is too long
29cbb25 Add command level arguments
17b8a10 Add Socket IPC docs
0a3efdf bump @types/node to 18.16.3
8988961 adjust to Node 18 types
6b04d03 Use LONG_RUNNING_TESTS env var

📊 Changes

9 files changed (+117 additions, -76 deletions)

View changed files

📝 README.md (+2 -0)
📝 package-lock.json (+7 -7)
📝 package.json (+1 -1)
📝 src/ipc/index.ts (+1 -1)
📝 src/ipc/service/index.ts (+43 -34)
📝 src/ipc/service/shared.ts (+12 -1)
📝 src/ipc/service/start.ts (+15 -2)
📝 src/ipc/socket.ts (+35 -29)
📝 src/test/bulk-import.spec.ts (+1 -1)

📄 Description

This fixes a process not being able to exit because the socket IPC was keeping references to stdout and stderr. It also adds some command level settings and documentation!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/appy-one/acebase/pull/224 **Author:** [@appy-one](https://github.com/appy-one) **Created:** 5/1/2023 **Status:** ✅ Merged **Merged:** 5/1/2023 **Merged by:** [@appy-one](https://github.com/appy-one) **Base:** `master` ← **Head:** `fix/socket-ipc` --- ### 📝 Commits (8) - [`8daa2b3`](https://github.com/appy-one/acebase/commit/8daa2b30585c2d082cb1cb6f3fb9bb39e73dc151) Work on socket IPC implementation: - [`a48341b`](https://github.com/appy-one/acebase/commit/a48341b9f689bfcd9f08e6a4ebe5e916a3435bd2) Add config settings, no console logging - [`8cc685a`](https://github.com/appy-one/acebase/commit/8cc685a7fbc552f74096ddf0837b90dc8989409f) use hash for socket/pipe if filePath is too long - [`29cbb25`](https://github.com/appy-one/acebase/commit/29cbb253c7a97dc203cc0f0ba5be507151757198) Add command level arguments - [`17b8a10`](https://github.com/appy-one/acebase/commit/17b8a10c188204d288c5fe3d520887f3ae267162) Add Socket IPC docs - [`0a3efdf`](https://github.com/appy-one/acebase/commit/0a3efdffea07bbecdd99e56bbe1df33d83310bea) bump @types/node to 18.16.3 - [`8988961`](https://github.com/appy-one/acebase/commit/8988961a5043252465a96f734e5667080f9a4f54) adjust to Node 18 types - [`6b04d03`](https://github.com/appy-one/acebase/commit/6b04d03ac11f262db91f0e7da65311908315dc76) Use LONG_RUNNING_TESTS env var ### 📊 Changes **9 files changed** (+117 additions, -76 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+2 -0) 📝 `package-lock.json` (+7 -7) 📝 `package.json` (+1 -1) 📝 `src/ipc/index.ts` (+1 -1) 📝 `src/ipc/service/index.ts` (+43 -34) 📝 `src/ipc/service/shared.ts` (+12 -1) 📝 `src/ipc/service/start.ts` (+15 -2) 📝 `src/ipc/socket.ts` (+35 -29) 📝 `src/test/bulk-import.spec.ts` (+1 -1) </details> ### 📄 Description This fixes a process not being able to exit because the socket IPC was keeping references to `stdout` and `stderr`. It also adds some command level settings and documentation! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>