[PR #216] [MERGED] Fix socket IPC breaking browser build #215 #172

New issue

Closed

opened 2026-05-23 08:32:32 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-23 08:32:32 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/appy-one/acebase/pull/216
Author: @appy-one
Created: 4/17/2023
Status: ✅ Merged
Merged: 4/17/2023
Merged by: @appy-one

Base: master ← Head: fix/cluster-ipc-breaking-browser-build

📝 Commits (1)

5d5536f Fix cluster IPC breaking browser build #215

📊 Changes

4 files changed (+11 additions, -7 deletions)

View changed files

📝 src/ipc/browser.ts (+5 -1)
📝 src/ipc/index.ts (+1 -0)
📝 src/ipc/socket.ts (+1 -0)
📝 src/storage/index.ts (+4 -6)

📄 Description

The new Socket IPC mode added in v1.28.0 (#213) broke the browser build because NodeJS components were being accessed in the browser context. This PR fixes #215

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/appy-one/acebase/pull/216 **Author:** [@appy-one](https://github.com/appy-one) **Created:** 4/17/2023 **Status:** ✅ Merged **Merged:** 4/17/2023 **Merged by:** [@appy-one](https://github.com/appy-one) **Base:** `master` ← **Head:** `fix/cluster-ipc-breaking-browser-build` --- ### 📝 Commits (1) - [`5d5536f`](https://github.com/appy-one/acebase/commit/5d5536f9f9efc95d9d3a1995d0b67c8edf67f767) Fix cluster IPC breaking browser build #215 ### 📊 Changes **4 files changed** (+11 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/ipc/browser.ts` (+5 -1) 📝 `src/ipc/index.ts` (+1 -0) 📝 `src/ipc/socket.ts` (+1 -0) 📝 `src/storage/index.ts` (+4 -6) </details> ### 📄 Description The new Socket IPC mode added in v1.28.0 (#213) broke the browser build because NodeJS components were being accessed in the browser context. This PR fixes #215 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>