github-starred/acebase

Fork 0

mirror of https://github.com/appy-one/acebase.git synced 2026-05-25 14:12:14 -06:00

[GH-ISSUE #17] Enable es6 import in Node.js #15

New issue

Closed

opened 2026-05-23 08:25:32 -06:00 by gitea-mirror · 7 comments

gitea-mirror commented

2026-05-23 08:25:32 -06:00

Owner

Originally created by @clibu on GitHub (Mar 4, 2021).
Original GitHub issue: https://github.com/appy-one/acebase/issues/17

I'm writing all my Node.js code using es6 import's however AceBase currently needs the following hack for import to work.

import pkg from 'acebase';
const { AceBase } = pkg;

Originally created by @clibu on GitHub (Mar 4, 2021). Original GitHub issue: https://github.com/appy-one/acebase/issues/17 I'm writing all my Node.js code using es6 import's however AceBase currently needs the following hack for import to work. ```` import pkg from 'acebase'; const { AceBase } = pkg; ````

gitea-mirror closed this issue

2026-05-23 08:25:33 -06:00

gitea-mirror commented

2026-05-23 08:25:36 -06:00

Author

Owner

@appy-one commented on GitHub (Mar 4, 2021):

Why not just use

import { AceBase } from 'acebase';

@appy-one commented on GitHub (Mar 4, 2021): Why not just use ```js import { AceBase } from 'acebase'; ```

gitea-mirror commented

2026-05-23 08:25:37 -06:00

Author

Owner

@clibu commented on GitHub (Mar 4, 2021):

import { AceBase } from 'acebase';
         ^^^^^^^
SyntaxError: The requested module 'acebase' is expected to be of type CommonJS, which does not support named exports. CommonJS modules can
be imported by importing the default export.
For example:
import pkg from 'acebase';
const { AceBase } = pkg;

@clibu commented on GitHub (Mar 4, 2021): ```` import { AceBase } from 'acebase'; ^^^^^^^ SyntaxError: The requested module 'acebase' is expected to be of type CommonJS, which does not support named exports. CommonJS modules can be imported by importing the default export. For example: import pkg from 'acebase'; const { AceBase } = pkg; ````

gitea-mirror commented

2026-05-23 08:25:38 -06:00

Author

Owner

@clibu commented on GitHub (Mar 4, 2021):

This is using "type": "module", in package.json

@clibu commented on GitHub (Mar 4, 2021): This is using ```"type": "module",``` in package.json

gitea-mirror commented

2026-05-23 08:25:38 -06:00

Author

Owner

@appy-one commented on GitHub (Mar 4, 2021):

I'm not able to reproduce?
If I set "type": "module" in my test package.json, I am able to use import { AceBase } from 'acebase'; without getting an error.
What node version are your using? I just tested with v14.15.4

@appy-one commented on GitHub (Mar 4, 2021): I'm not able to reproduce? If I set ```"type": "module"``` in my test package.json, I am able to use ```import { AceBase } from 'acebase';``` without getting an error. What node version are your using? I just tested with v14.15.4

gitea-mirror commented

2026-05-23 08:25:39 -06:00

Author

Owner

@appy-one commented on GitHub (Mar 4, 2021):

Apparently this is possible since Node v14.13.0, see this tweet, or this blog post about it: Node.js now supports named imports from CommonJS modules, but what does that mean?

@appy-one commented on GitHub (Mar 4, 2021): Apparently this is possible since Node v14.13.0, see [this tweet](https://twitter.com/MylesBorins/status/1311033983824793601), or this blog post about it: [Node.js now supports named imports from CommonJS modules, but what does that mean?](https://simonplend.com/node-js-now-supports-named-imports-from-commonjs-modules-but-what-does-that-mean/)

gitea-mirror commented

2026-05-23 08:25:43 -06:00

Author

Owner

@clibu commented on GitHub (Mar 4, 2021):

I am using 14.7.0 which works fine with es6 modules. I've just updated to 15.11.0 and import works now.

Whether you want to try and support older versions of Node is a question for you.😀

Did you notice my discussion post: https://github.com/appy-one/acebase/discussions/13

@clibu commented on GitHub (Mar 4, 2021): I am using 14.7.0 which works fine with es6 modules. I've just updated to 15.11.0 and import works now. Whether you want to try and support older versions of Node is a question for you.😀 Did you notice my discussion post: https://github.com/appy-one/acebase/discussions/13

gitea-mirror commented

2026-05-23 08:25:43 -06:00

Author

Owner

@appy-one commented on GitHub (Mar 4, 2021):

Sorry, didn't see the discussion earlier. Somehow the GitHub notification emails are not always getting through...

AceBase supports older Node versions, I haven't checked it but should at least be compatible back to version 7. If I switch to using ES modules, that would mean dropping support for older Node versions. And with the Node team already having fixed mixing CommonJS / ES modules, I'd say "don't fix it if it ain't broken"! 😄

@appy-one commented on GitHub (Mar 4, 2021): Sorry, didn't see the discussion earlier. Somehow the GitHub notification emails are not always getting through... AceBase supports older Node versions, I haven't checked it but should at least be compatible back to version 7. If I switch to using ES modules, that would mean dropping support for older Node versions. And with the Node team already having fixed mixing CommonJS / ES modules, I'd say "don't fix it if it ain't broken"! 😄