[PR #51] [MERGED] Improvement: RouteRequest types and shutdown console logs #53

New issue

Closed

opened 2026-05-23 08:39:36 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-23 08:39:36 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/appy-one/acebase-server/pull/51
Author: @appy-one
Created: 11/23/2022
Status: ✅ Merged
Merged: 11/23/2022
Merged by: @appy-one

Base: master ← Head: improvement/misc-20221123

📝 Commits (3)

d13f70b Reorder RouteRequest types: query, body, resBody
3618fc7 Improve shutdown console logs
37b2970 chore: build

📊 Changes

125 files changed (+167 additions, -163 deletions)

View changed files

📝 dist/cjs/middleware/user.js.map (+1 -1)
📝 dist/cjs/routes/data-index-create.js.map (+1 -1)
📝 dist/cjs/routes/oauth2-init.js (+8 -5)
📝 dist/cjs/routes/oauth2-init.js.map (+1 -1)
📝 dist/cjs/server.js (+8 -9)
📝 dist/cjs/server.js.map (+1 -1)
📝 dist/esm/middleware/user.js.map (+1 -1)
📝 dist/esm/routes/data-index-create.js.map (+1 -1)
📝 dist/esm/routes/oauth2-init.js (+8 -5)
📝 dist/esm/routes/oauth2-init.js.map (+1 -1)
📝 dist/esm/server.js (+8 -9)
📝 dist/esm/server.js.map (+1 -1)
📝 dist/types/routes/auth-change-password.d.ts (+1 -1)
📝 dist/types/routes/auth-change-password.d.ts.map (+1 -1)
📝 dist/types/routes/auth-delete.d.ts (+1 -1)
📝 dist/types/routes/auth-delete.d.ts.map (+1 -1)
📝 dist/types/routes/auth-forgot-password.d.ts (+1 -1)
📝 dist/types/routes/auth-forgot-password.d.ts.map (+1 -1)
📝 dist/types/routes/auth-reset-password.d.ts (+1 -1)
📝 dist/types/routes/auth-reset-password.d.ts.map (+1 -1)

...and 80 more files

📄 Description

Replaced console.log in shutdown procedure with this.debug.log to adhere the user logging level. Also removed an invalid log message about 0 clients still connected after shutdown timeout.

I noticed the tsc build was failing due to changes in Express, so I had to change the RouteRequest type used by endpoints. Took the opportunity to reorder the order of the type args to be more logical: 1. Request Query, 2. Request Body, Response Body.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/appy-one/acebase-server/pull/51 **Author:** [@appy-one](https://github.com/appy-one) **Created:** 11/23/2022 **Status:** ✅ Merged **Merged:** 11/23/2022 **Merged by:** [@appy-one](https://github.com/appy-one) **Base:** `master` ← **Head:** `improvement/misc-20221123` --- ### 📝 Commits (3) - [`d13f70b`](https://github.com/appy-one/acebase-server/commit/d13f70bac9f21255994a6631673b8d04716d610e) Reorder RouteRequest types: query, body, resBody - [`3618fc7`](https://github.com/appy-one/acebase-server/commit/3618fc7ae2fd94b716869809aeb1a6bef2bc1ffe) Improve shutdown console logs - [`37b2970`](https://github.com/appy-one/acebase-server/commit/37b29701cdc93d1c10eb9a017076862bfcff46d2) chore: build ### 📊 Changes **125 files changed** (+167 additions, -163 deletions) <details> <summary>View changed files</summary> 📝 `dist/cjs/middleware/user.js.map` (+1 -1) 📝 `dist/cjs/routes/data-index-create.js.map` (+1 -1) 📝 `dist/cjs/routes/oauth2-init.js` (+8 -5) 📝 `dist/cjs/routes/oauth2-init.js.map` (+1 -1) 📝 `dist/cjs/server.js` (+8 -9) 📝 `dist/cjs/server.js.map` (+1 -1) 📝 `dist/esm/middleware/user.js.map` (+1 -1) 📝 `dist/esm/routes/data-index-create.js.map` (+1 -1) 📝 `dist/esm/routes/oauth2-init.js` (+8 -5) 📝 `dist/esm/routes/oauth2-init.js.map` (+1 -1) 📝 `dist/esm/server.js` (+8 -9) 📝 `dist/esm/server.js.map` (+1 -1) 📝 `dist/types/routes/auth-change-password.d.ts` (+1 -1) 📝 `dist/types/routes/auth-change-password.d.ts.map` (+1 -1) 📝 `dist/types/routes/auth-delete.d.ts` (+1 -1) 📝 `dist/types/routes/auth-delete.d.ts.map` (+1 -1) 📝 `dist/types/routes/auth-forgot-password.d.ts` (+1 -1) 📝 `dist/types/routes/auth-forgot-password.d.ts.map` (+1 -1) 📝 `dist/types/routes/auth-reset-password.d.ts` (+1 -1) 📝 `dist/types/routes/auth-reset-password.d.ts.map` (+1 -1) _...and 80 more files_ </details> ### 📄 Description Replaced `console.log` in shutdown procedure with `this.debug.log` to adhere the user logging level. Also removed an invalid log message about 0 clients still connected after shutdown timeout. I noticed the tsc build was failing due to changes in Express, so I had to change the `RouteRequest` type used by endpoints. Took the opportunity to reorder the order of the type args to be more logical: 1. Request Query, 2. Request Body, Response Body. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>