[PR #29] [MERGED] Fix ESM rootpath #36

New issue

Closed

opened 2026-05-23 08:39:13 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-23 08:39:13 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/appy-one/acebase-server/pull/29
Author: @appy-one
Created: 9/6/2022
Status: ✅ Merged
Merged: 9/10/2022
Merged by: @appy-one

Base: master ← Head: fix/rootpath

📝 Commits (2)

8b73c2a Fix ESM rootpath issue
6b27b70 chore: build

📊 Changes

5 files changed (+8 additions, -2 deletions)

View changed files

📝 dist/cjs/shared/rootpath.js (+2 -0)
📝 dist/cjs/shared/rootpath.js.map (+1 -1)
📝 dist/esm/shared/rootpath.js (+2 -0)
📝 dist/esm/shared/rootpath.js.map (+1 -1)
📝 src/shared/rootpath.ts (+2 -0)

📄 Description

tsc-esm-fix does not unescape urls gotten from import.meta.url, so "non-url-friendly characters" such as spaces are left in there as %20. This causes databases in paths with special characters not being able to be created/opened. Adding decodeURI fixes this for now.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/appy-one/acebase-server/pull/29 **Author:** [@appy-one](https://github.com/appy-one) **Created:** 9/6/2022 **Status:** ✅ Merged **Merged:** 9/10/2022 **Merged by:** [@appy-one](https://github.com/appy-one) **Base:** `master` ← **Head:** `fix/rootpath` --- ### 📝 Commits (2) - [`8b73c2a`](https://github.com/appy-one/acebase-server/commit/8b73c2abae8d7a6c2966676e9867a31d197b9663) Fix ESM rootpath issue - [`6b27b70`](https://github.com/appy-one/acebase-server/commit/6b27b708d2109715f8bd345e3c1c5750dcfe24af) chore: build ### 📊 Changes **5 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `dist/cjs/shared/rootpath.js` (+2 -0) 📝 `dist/cjs/shared/rootpath.js.map` (+1 -1) 📝 `dist/esm/shared/rootpath.js` (+2 -0) 📝 `dist/esm/shared/rootpath.js.map` (+1 -1) 📝 `src/shared/rootpath.ts` (+2 -0) </details> ### 📄 Description `tsc-esm-fix` does not unescape urls gotten from `import.meta.url`, so "non-url-friendly characters" such as spaces are left in there as `%20`. This causes databases in paths with special characters not being able to be created/opened. Adding `decodeURI` fixes this for now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>