[PR #28] [CLOSED] Fix: ESM rootpath issue #35

New issue

Closed

opened 2026-05-23 08:39:09 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-23 08:39:09 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/appy-one/acebase-server/pull/28
Author: @appy-one
Created: 9/6/2022
Status: ❌ Closed

Base: master ← Head: fix/windows-rootpath

📝 Commits (2)

b4c90f0 Fix ESM rootpath on windows issue
463a31f chore: build

📊 Changes

6 files changed (+22 additions, -3 deletions)

View changed files

📝 create-package-files (+14 -1)
📝 dist/cjs/shared/rootpath.js (+2 -0)
📝 dist/cjs/shared/rootpath.js.map (+1 -1)
📝 dist/esm/shared/rootpath.js (+2 -0)
📝 dist/esm/shared/rootpath.js.map (+1 -1)
📝 src/shared/rootpath.ts (+2 -0)

📄 Description

tsc-esm-fix does not unescape urls gotten from import.meta.url, so "non-url-friendly characters" such as spaces are left in there as %20. This causes databases in paths with special characters not being able to be created/opened. Adding decodeURI fixes this for now.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/appy-one/acebase-server/pull/28 **Author:** [@appy-one](https://github.com/appy-one) **Created:** 9/6/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/windows-rootpath` --- ### 📝 Commits (2) - [`b4c90f0`](https://github.com/appy-one/acebase-server/commit/b4c90f013309612e66ba3afb9a0ea99588473af3) Fix ESM rootpath on windows issue - [`463a31f`](https://github.com/appy-one/acebase-server/commit/463a31fded8f2276d31a2961386baf06efaa7b7d) chore: build ### 📊 Changes **6 files changed** (+22 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `create-package-files` (+14 -1) 📝 `dist/cjs/shared/rootpath.js` (+2 -0) 📝 `dist/cjs/shared/rootpath.js.map` (+1 -1) 📝 `dist/esm/shared/rootpath.js` (+2 -0) 📝 `dist/esm/shared/rootpath.js.map` (+1 -1) 📝 `src/shared/rootpath.ts` (+2 -0) </details> ### 📄 Description `tsc-esm-fix` does not unescape urls gotten from `import.meta.url`, so "non-url-friendly characters" such as spaces are left in there as `%20`. This causes databases in paths with special characters not being able to be created/opened. Adding `decodeURI` fixes this for now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>