[PR #13] [MERGED] Fix esm and sync timestamp parsing #33

New issue

Closed

opened 2026-05-23 08:39:08 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-23 08:39:08 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/appy-one/acebase-server/pull/13
Author: @akvadrako
Created: 4/28/2022
Status: ✅ Merged
Merged: 4/29/2022
Merged by: @appy-one

Base: master ← Head: fix-esm-and-sync-timestamp-parsing

📝 Commits (5)

b1daad3 Fix ESM compile
b29670a Fix meta docs
c8b37b6 Fix sync timestamp parsing
2d1c493 compile
4a4bcb3 fix typo

📊 Changes

11 files changed (+17 additions, -11 deletions)

View changed files

📝 dist/cjs/routes/data-sync-changes.js (+3 -1)
📝 dist/cjs/routes/data-sync-changes.js.map (+1 -1)
📝 dist/cjs/routes/meta-info.js (+1 -1)
📝 dist/cjs/routes/meta-info.js.map (+1 -1)
📝 dist/esm/routes/data-sync-changes.js (+3 -1)
📝 dist/esm/routes/data-sync-changes.js.map (+1 -1)
📝 dist/esm/routes/meta-info.js (+1 -1)
📝 dist/esm/routes/meta-info.js.map (+1 -1)
📝 src/routes/data-sync-changes.ts (+3 -1)
📝 src/routes/meta-info.ts (+1 -1)
📝 src/routes/meta-info.yaml (+1 -1)

📄 Description

This fixes a few small issues I had while testing the sync endpoint.

meta-info docs said seconds when they meant ms
I am using ES6 modules, which doesn't support require()
the timestamp query param was a string, but was expected to be a integer. Probably this is something that could be cleaned up a bit.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/appy-one/acebase-server/pull/13 **Author:** [@akvadrako](https://github.com/akvadrako) **Created:** 4/28/2022 **Status:** ✅ Merged **Merged:** 4/29/2022 **Merged by:** [@appy-one](https://github.com/appy-one) **Base:** `master` ← **Head:** `fix-esm-and-sync-timestamp-parsing` --- ### 📝 Commits (5) - [`b1daad3`](https://github.com/appy-one/acebase-server/commit/b1daad3df2b4ffdf2cc0d87187ed731f6f6a9b68) Fix ESM compile - [`b29670a`](https://github.com/appy-one/acebase-server/commit/b29670a376057efe16da38a0dab87cd2976abad9) Fix meta docs - [`c8b37b6`](https://github.com/appy-one/acebase-server/commit/c8b37b60caaeb822b168c6e1c47fc9a2bb5e2b5b) Fix sync timestamp parsing - [`2d1c493`](https://github.com/appy-one/acebase-server/commit/2d1c4930a4d7b9d845a2260d987b00f72336a77f) compile - [`4a4bcb3`](https://github.com/appy-one/acebase-server/commit/4a4bcb390f717dd6a3ac684eabd69b9ac32de59d) fix typo ### 📊 Changes **11 files changed** (+17 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `dist/cjs/routes/data-sync-changes.js` (+3 -1) 📝 `dist/cjs/routes/data-sync-changes.js.map` (+1 -1) 📝 `dist/cjs/routes/meta-info.js` (+1 -1) 📝 `dist/cjs/routes/meta-info.js.map` (+1 -1) 📝 `dist/esm/routes/data-sync-changes.js` (+3 -1) 📝 `dist/esm/routes/data-sync-changes.js.map` (+1 -1) 📝 `dist/esm/routes/meta-info.js` (+1 -1) 📝 `dist/esm/routes/meta-info.js.map` (+1 -1) 📝 `src/routes/data-sync-changes.ts` (+3 -1) 📝 `src/routes/meta-info.ts` (+1 -1) 📝 `src/routes/meta-info.yaml` (+1 -1) </details> ### 📄 Description This fixes a few small issues I had while testing the sync endpoint. 1) meta-info docs said *seconds* when they meant *ms* 2) I am using ES6 modules, which doesn't support `require()` 3) the `timestamp` query param was a string, but was expected to be a integer. Probably this is something that could be cleaned up a bit. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>