[PR #43] [MERGED] Fix for Observable export since usage of tsc 5.0.4 #42

New issue

Closed

opened 2026-05-23 08:37:18 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-23 08:37:18 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/appy-one/acebase-core/pull/43
Author: @appy-one
Created: 5/22/2023
Status: ✅ Merged
Merged: 5/22/2023
Merged by: @appy-one

Base: master ← Head: fix/optional-observable-export-tsc-lt-5.0

📝 Commits (1)

0411f31 Fix for Observable export since usage of tsc 5.0.4

📊 Changes

1 file changed (+2 additions, -3 deletions)

View changed files

📝 src/optional-observable.ts (+2 -3)

📄 Description

Apps using acebase(/-core) with typescript version < 5.0 and skipLibCheck set to false would get error:

[Error: node_modules/acebase-core/dist/types/optional-observable.d.ts:5:68 - error TS1144: '{' or ';' expected.
export declare function getObservable<T = any>(): typeof Observable<T>;
                                                                   ^

This was introduced when acebase-core started using typescript 5.0.4

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/appy-one/acebase-core/pull/43 **Author:** [@appy-one](https://github.com/appy-one) **Created:** 5/22/2023 **Status:** ✅ Merged **Merged:** 5/22/2023 **Merged by:** [@appy-one](https://github.com/appy-one) **Base:** `master` ← **Head:** `fix/optional-observable-export-tsc-lt-5.0` --- ### 📝 Commits (1) - [`0411f31`](https://github.com/appy-one/acebase-core/commit/0411f3138a92e70fa47d07b651dbf82734901c4d) Fix for Observable export since usage of tsc 5.0.4 ### 📊 Changes **1 file changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/optional-observable.ts` (+2 -3) </details> ### 📄 Description Apps using acebase(/-core) with typescript version < 5.0 and `skipLibCheck` set to `false` would get error: ``` [Error: node_modules/acebase-core/dist/types/optional-observable.d.ts:5:68 - error TS1144: '{' or ';' expected. export declare function getObservable<T = any>(): typeof Observable<T>; ^ ``` This was introduced when acebase-core started using typescript 5.0.4 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>