github-starred/acebase-core

Fork 0

mirror of https://github.com/appy-one/acebase-core.git synced 2026-05-24 22:01:23 -06:00

[PR #37] [MERGED] DataSnapshot `child` and `forEach` type improvements #38

New issue

Closed

opened 2026-05-23 08:37:10 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-23 08:37:10 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/appy-one/acebase-core/pull/37
Author: @appy-one
Created: 4/3/2023
Status: ✅ Merged
Merged: 4/3/2023
Merged by: @appy-one

Base: master ← Head: datareference-datasnapshot-generics

📝 Commits (4)

00a318a 1) let child property inherit from parent type,
7c34acb let forEach inherit child types by default
160c286 MutationsDataSnapshot: override child type
a549220 added typechecking playground

📊 Changes

2 files changed (+34 additions, -3 deletions)

View changed files

➕ src/data-reference.spec.ts (+27 -0)
📝 src/data-snapshot.ts (+7 -3)

📄 Description

In addition to @futurGH's great work to implement type generics in #34, I improved the types of the DataSnapshot.child, DataSnapshot.forEach and MutationDataSnapshot.child methods

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/appy-one/acebase-core/pull/37 **Author:** [@appy-one](https://github.com/appy-one) **Created:** 4/3/2023 **Status:** ✅ Merged **Merged:** 4/3/2023 **Merged by:** [@appy-one](https://github.com/appy-one) **Base:** `master` ← **Head:** `datareference-datasnapshot-generics` --- ### 📝 Commits (4) - [`00a318a`](https://github.com/appy-one/acebase-core/commit/00a318a1bfdc0a2fa81534f2c789ac20201e7b1a) 1) let `child` property inherit from parent type, - [`7c34acb`](https://github.com/appy-one/acebase-core/commit/7c34acb7f32c05ccf1c569136c7070f5175985b6) let `forEach` inherit child types by default - [`160c286`](https://github.com/appy-one/acebase-core/commit/160c2865f114f0308c081eec57f89f0f701eda8f) `MutationsDataSnapshot`: override `child` type - [`a549220`](https://github.com/appy-one/acebase-core/commit/a5492206eb7c876c99b351f04cd2007a66f9f136) added typechecking playground ### 📊 Changes **2 files changed** (+34 additions, -3 deletions) <details> <summary>View changed files</summary> ➕ `src/data-reference.spec.ts` (+27 -0) 📝 `src/data-snapshot.ts` (+7 -3) </details> ### 📄 Description In addition to @futurGH's great work to implement type generics in #34, I improved the types of the `DataSnapshot.child`, `DataSnapshot.forEach` and `MutationDataSnapshot.child` methods --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-23 08:37:10 -06:00

closed this issue
added the
pull-request
label

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/acebase-core#38

No description provided.

Rows
Columns

[PR #37] [MERGED] DataSnapshot child and forEach type improvements #38

📋 Pull Request Information

📝 Commits (4)

📊 Changes

📄 Description

[PR #37] [MERGED] DataSnapshot `child` and `forEach` type improvements #38