[PR #21] [MERGED] Moved types and jsdocs into sources #22

New issue

Closed

opened 2026-05-23 08:36:51 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-23 08:36:51 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/appy-one/acebase-core/pull/21
Author: @appy-one
Created: 10/3/2022
Status: ✅ Merged
Merged: 10/24/2022
Merged by: @appy-one

Base: master ← Head: fix/use-generated-types

📝 Commits (10+)

992585a Moved types and jsdocs into sources
6a50a83 Moved more jsdocs into sources,
15fcc30 code & type improvements & fixes
1feb457 Added @internal annotations
65c262a Api adjustments for acebase and acebase-client
30e1a74 * moved deprecated export signature here,
f093639 added @internal annotation
9db2638 public level
8f4e818 concatTypesArrays type improvement
e512053 Added @internal annotation

📊 Changes

164 files changed (+3481 additions, -1896 deletions)

View changed files

📝 .npmignore (+7 -6)
📝 create-package-files (+23 -10)
📝 dist/cjs/acebase-base.js (+52 -40)
📝 dist/cjs/acebase-base.js.map (+1 -1)
📝 dist/cjs/api.js (+3 -3)
📝 dist/cjs/api.js.map (+1 -1)
📝 dist/cjs/data-proxy.js (+16 -0)
📝 dist/cjs/data-proxy.js.map (+1 -1)
📝 dist/cjs/data-reference.js (+57 -67)
📝 dist/cjs/data-reference.js.map (+1 -1)
📝 dist/cjs/data-snapshot.js (+15 -9)
📝 dist/cjs/data-snapshot.js.map (+1 -1)
📝 dist/cjs/debug.js (+1 -1)
📝 dist/cjs/debug.js.map (+1 -1)
📝 dist/cjs/id.js (+4 -0)
📝 dist/cjs/id.js.map (+1 -1)
📝 dist/cjs/index.d.ts (+1 -1)
📝 dist/cjs/index.js (+6 -5)
📝 dist/cjs/index.js.map (+1 -1)
📝 dist/cjs/object-collection.js (+36 -0)

...and 80 more files

📄 Description

Type definitions can now be generated by tsc

TODO

check if all types and jsdocs in root types dir are implemented in src files
remove root types directory
build & commit

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/appy-one/acebase-core/pull/21 **Author:** [@appy-one](https://github.com/appy-one) **Created:** 10/3/2022 **Status:** ✅ Merged **Merged:** 10/24/2022 **Merged by:** [@appy-one](https://github.com/appy-one) **Base:** `master` ← **Head:** `fix/use-generated-types` --- ### 📝 Commits (10+) - [`992585a`](https://github.com/appy-one/acebase-core/commit/992585a9a559dac0e0728356ba23334d2e36cea0) Moved types and jsdocs into sources - [`6a50a83`](https://github.com/appy-one/acebase-core/commit/6a50a8375fbe44488852c01077f09591c4bf8738) Moved more jsdocs into sources, - [`15fcc30`](https://github.com/appy-one/acebase-core/commit/15fcc30df6cee1efdab2e6c782744600752e952f) code & type improvements & fixes - [`1feb457`](https://github.com/appy-one/acebase-core/commit/1feb457bd8c8aec6c2ea1fb19af55cb8ed0865c7) Added @internal annotations - [`65c262a`](https://github.com/appy-one/acebase-core/commit/65c262a2c9cae0c506e3a27697afa63ef13c528d) Api adjustments for acebase and acebase-client - [`30e1a74`](https://github.com/appy-one/acebase-core/commit/30e1a744dbefb64f2c1a0fba55761391de2c19e3) * moved deprecated export signature here, - [`f093639`](https://github.com/appy-one/acebase-core/commit/f09363950b97aafed091e1dda76f4a8643a728a3) added @internal annotation - [`9db2638`](https://github.com/appy-one/acebase-core/commit/9db263825e9e986819aff069ddc727ee390dce1f) public level - [`8f4e818`](https://github.com/appy-one/acebase-core/commit/8f4e818f0601b1de49a5ebc3aa0f96f5037e850a) concatTypesArrays type improvement - [`e512053`](https://github.com/appy-one/acebase-core/commit/e51205365daeb3b7cbca1f58b8e071d830c7527a) Added @internal annotation ### 📊 Changes **164 files changed** (+3481 additions, -1896 deletions) <details> <summary>View changed files</summary> 📝 `.npmignore` (+7 -6) 📝 `create-package-files` (+23 -10) 📝 `dist/cjs/acebase-base.js` (+52 -40) 📝 `dist/cjs/acebase-base.js.map` (+1 -1) 📝 `dist/cjs/api.js` (+3 -3) 📝 `dist/cjs/api.js.map` (+1 -1) 📝 `dist/cjs/data-proxy.js` (+16 -0) 📝 `dist/cjs/data-proxy.js.map` (+1 -1) 📝 `dist/cjs/data-reference.js` (+57 -67) 📝 `dist/cjs/data-reference.js.map` (+1 -1) 📝 `dist/cjs/data-snapshot.js` (+15 -9) 📝 `dist/cjs/data-snapshot.js.map` (+1 -1) 📝 `dist/cjs/debug.js` (+1 -1) 📝 `dist/cjs/debug.js.map` (+1 -1) 📝 `dist/cjs/id.js` (+4 -0) 📝 `dist/cjs/id.js.map` (+1 -1) 📝 `dist/cjs/index.d.ts` (+1 -1) 📝 `dist/cjs/index.js` (+6 -5) 📝 `dist/cjs/index.js.map` (+1 -1) 📝 `dist/cjs/object-collection.js` (+36 -0) _...and 80 more files_ </details> ### 📄 Description Type definitions can now be generated by tsc TODO - [x] check if all types and jsdocs in root `types` dir are implemented in `src` files - [x] remove root `types` directory - [x] build & commit --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>