[GH-ISSUE #1] Proxyfied array .indexOf issue #2

New issue

Closed

opened 2026-05-23 08:36:09 -06:00 by gitea-mirror · 1 comment

gitea-mirror commented

2026-05-23 08:36:09 -06:00

Owner

Originally created by @appy-one on GitHub (Feb 18, 2021).
Original GitHub issue: https://github.com/appy-one/acebase-core/issues/1

Originally assigned to: @appy-one on GitHub.

The indexOf function of a proxified array value does not return expected result.

Example:

const proxy = await db.ref('chats/chat1').proxy();
const liveChat = proxy.value;
const member1 = liveChat.members[0]; // Assuming members is an array of objects
liveChat.members.indexOf(member1); // -1, should be 0

The reason this fails, is because member1 is the proxified version of the object, which is not found in the internal array of liveChat.members.

Current workaround is to use getTarget() on member1:

liveChat.members.indexOf(member1.getTarget()); // === 0

Suggested fix: override indexOf in data-proxy.ts and check if provided value is a Proxy, if so, call getTarget() on it and pass it on to native indexOf.

Originally created by @appy-one on GitHub (Feb 18, 2021). Original GitHub issue: https://github.com/appy-one/acebase-core/issues/1 Originally assigned to: @appy-one on GitHub. The ```indexOf``` function of a proxified array value does not return expected result. Example: ```js const proxy = await db.ref('chats/chat1').proxy(); const liveChat = proxy.value; const member1 = liveChat.members[0]; // Assuming members is an array of objects liveChat.members.indexOf(member1); // -1, should be 0 ``` The reason this fails, is because ```member1``` is the proxified version of the object, which is not found in the internal array of ```liveChat.members```. Current workaround is to use ```getTarget()``` on ```member1```: ```js liveChat.members.indexOf(member1.getTarget()); // === 0 ``` Suggested fix: override ```indexOf``` in [data-proxy.ts](https://github.com/appy-one/acebase-core/blob/master/src/data-proxy.ts#L710) and check if provided value is a Proxy, if so, call ```getTarget()``` on it and pass it on to native ```indexOf```.