[PR #14] [MERGED] fix typescript declaration #18

New issue

Closed

opened 2026-05-23 08:36:44 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-23 08:36:44 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/appy-one/acebase-core/pull/14
Author: @Mitsichury
Created: 8/21/2022
Status: ✅ Merged
Merged: 8/29/2022
Merged by: @appy-one

Base: master ← Head: fix/ttypescript

📝 Commits (1)

142302b should do the trick

📊 Changes

1 file changed (+6 additions, -4 deletions)

View changed files

📝 src/simple-event-emitter.ts (+6 -4)

📄 Description

Hi :)
Since the last release of acebase package the typescript linter won't authorize compilation.

I have enable the strict mode for my project.
The compiler look for all typescript files even in node_modules (known issue).

The export declaration works with include declaration for excpetion but does not configure the compiler to exlcude node modules :(
SkipLibCheck is meant to avoid d.ts files.

A solution is to avoid packaging ts files when deploying.

Could you add this modification please ? :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/appy-one/acebase-core/pull/14 **Author:** [@Mitsichury](https://github.com/Mitsichury) **Created:** 8/21/2022 **Status:** ✅ Merged **Merged:** 8/29/2022 **Merged by:** [@appy-one](https://github.com/appy-one) **Base:** `master` ← **Head:** `fix/ttypescript` --- ### 📝 Commits (1) - [`142302b`](https://github.com/appy-one/acebase-core/commit/142302bbeff8e30dd568e4bdbd4681aa1642754c) should do the trick ### 📊 Changes **1 file changed** (+6 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/simple-event-emitter.ts` (+6 -4) </details> ### 📄 Description Hi :) Since the last release of acebase package the typescript linter won't authorize compilation. I have enable the strict mode for my project. The compiler look for all typescript files even in node_modules (known issue). The export declaration works with include declaration for excpetion but does not configure the compiler to exlcude node modules :( SkipLibCheck is meant to avoid d.ts files. A solution is to avoid packaging ts files when deploying. Could you add this modification please ? :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>