github-starred/acebase-client
2
0
Fork 0
mirror of https://github.com/appy-one/acebase-client.git synced 2026-05-24 22:01:18 -06:00
Code Issues 5 Projects Packages Wiki Activity Actions

[PR #70] [MERGED] Split isNetworkError and isServerError up for better handling #61

New issue
Closed
opened 2026-05-23 08:35:36 -06:00 by gitea-mirror · 0 comments
gitea-mirror commented 2026-05-23 08:35:36 -06:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/appy-one/acebase-client/pull/70
Author: @appy-one
Created: 3/28/2025
Status: ✅ Merged
Merged: 3/28/2025
Merged by: @appy-one

Base: master ← Head: fix/use-own-property-for-server-errors

📝 Commits (1)

  • b2abc6f Split isNetworkError and isServerError up for better handling

📊 Changes

2 files changed (+12 additions, -8 deletions)

View changed files

📝 src/api-web.ts (+7 -7)
📝 src/request/error.ts (+5 -1)

📄 Description

Inclusion of the error code responses into isNetworkError created unwanted side effects, so I decided to move them to isServerError to handle them separately. These 2 combined are now "retryable errors"

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/appy-one/acebase-client/pull/70 **Author:** [@appy-one](https://github.com/appy-one) **Created:** 3/28/2025 **Status:** ✅ Merged **Merged:** 3/28/2025 **Merged by:** [@appy-one](https://github.com/appy-one) **Base:** `master` ← **Head:** `fix/use-own-property-for-server-errors` --- ### 📝 Commits (1) - [`b2abc6f`](https://github.com/appy-one/acebase-client/commit/b2abc6fb296362a300601efa69763343bd8a076d) Split `isNetworkError` and `isServerError` up for better handling ### 📊 Changes **2 files changed** (+12 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/api-web.ts` (+7 -7) 📝 `src/request/error.ts` (+5 -1) </details> ### 📄 Description Inclusion of the error code responses into `isNetworkError` created unwanted side effects, so I decided to move them to `isServerError` to handle them separately. These 2 combined are now "retryable errors" --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-23 08:35:36 -06:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
use-socket-io-client-4-8-3
improvement/combine-mutations-in-single-updates
dependabot/npm_and_yarn/word-wrap-1.2.4
dependabot/npm_and_yarn/test/socket.io-parser-4.2.4
dependencies/acebase-core-1.25.0
dependencies/acebase-core-1.22.4
dependencies/terser-5.15.0
v1.22.3
v1.22.3-rc.3
v1.22.3-rc.2
v1.22.3-rc.1
v1.22.2
v1.22.1
v1.22.0
v1.21.1
v1.21.0
v1.20.1
v1.20.0
v1.19.1
v1.19.0
v1.18.3
v1.18.2
v1.18.1
v1.18.0
v1.17.2
v1.17.1
v1.17.0
v1.16.0
v1.15.0
v1.14.0
v1.13.0
Labels
Clear labels   
bug

   
bug

   
dependencies

   
enhancement

   
enhancement

   
feature request

   
pull-request

Mirrored from GitHub Pull Request

No labels
bug
bug
dependencies
enhancement
enhancement
feature request
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/acebase-client#61
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?