[PR #29] [MERGED] drivers: drop the append-duplicated Server Name line from driver config tables #84

New issue

Closed

opened 2026-11-03 22:04:29 -07:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-11-03 22:04:29 -07:00

Owner

📋 Pull Request Information

Original PR: https://github.com/RhapsodiOS/RhapsodiOS/pull/29
Author: @raynorpat
Created: 9/25/2026
Status: ✅ Merged
Merged: 9/25/2026
Merged by: @raynorpat

Base: master ← Head: claude/competent-pare-e06a24

📝 Commits (2)

f529759 drivers: drop the "Server Name" line the build already appends from 39 Default.tables
e6fbf72 drivers: drop the append-duplicated "Server Name" line from 36 more tables

📊 Changes

94 files changed (+323 additions, -77 deletions)

View changed files

📝 src/drivers-i386/bus/Intel82365PCMCIA/PCIC.drvproj/Default.table (+0 -1)
📝 src/drivers-i386/bus/Intel82365PCMCIA/PCIC.drvproj/PCI.table (+0 -1)
📝 src/drivers-i386/bus/Intel82365PCMCIA/reconstruction/divergences.md (+21 -0)
📝 src/drivers-i386/bus/Intel824X0PCI/Intel824X0.drvproj/Default.table (+0 -2)
📝 src/drivers-i386/bus/Intel824X0PCI/reconstruction/divergences.md (+20 -0)
📝 src/drivers-i386/bus/drvEISABus/EISABus.drvproj/Default.table (+0 -1)
📝 src/drivers-i386/bus/drvPCIBus/PCIBus.drvproj/Default.table (+0 -1)
📝 src/drivers-i386/bus/drvPCIBus/reconstruction/divergences.md (+22 -0)
📝 src/drivers-i386/bus/drvPCMCIABus/PCMCIABus.drvproj/Default.table (+0 -1)
📝 src/drivers-i386/ide/drvAHCI/AHCI.drvproj/Default.table (+0 -1)
📝 src/drivers-i386/ide/drvEIDE/EIDE.drvproj/Default.table (+0 -1)
📝 src/drivers-i386/ide/drvEIDE/EIDE.drvproj/Dual_EIDE.table (+0 -1)
📝 src/drivers-i386/ide/drvEIDE/EIDE.drvproj/EIDE_PIIX.table (+0 -1)
📝 src/drivers-i386/ide/drvEIDE/EIDE.drvproj/PnP_EIDE.table (+0 -1)
📝 src/drivers-i386/ide/drvPCFloppy/Floppy.drvproj/Default.table (+0 -1)
📝 src/drivers-i386/ide/drvPCFloppy/reconstruction/divergences.md (+13 -0)
📝 src/drivers-i386/input/drvBusMouse/BusMouse.drvproj/Default.table (+0 -1)
📝 src/drivers-i386/input/drvBusMouse/reconstruction/divergences.md (+12 -0)
📝 src/drivers-i386/input/drvISASerialPort/ISASerialPort.drvproj/Default.table (+0 -1)
📝 src/drivers-i386/input/drvISASerialPort/reconstruction/divergences.md (+12 -0)

...and 74 more files

📄 Description

Summary

The driver build's post_copy_tables rule appends "Server Name" = "$(NAME)"; to every table it copies into the built bundle, so a source table carrying its own "Server Name" line gets it twice in the built product.
Removes that duplicate line from 75 tables across drivers-i386, drivers-ppc, drvPortServer, and drvSCSIServer (any .table file actually listed in its project's GLOBAL_RESOURCES), leaving tables whose value differs from NAME untouched and noted.
EIDE, Intel824X0, SerialPointingDevice, and CirrusLogicGD5434 also had Apple's own table carrying the line twice; the extra copy is removed as a labelled divergence from the reference.
PCIBus's Default.table carried "Server Name" = "BUS", which nothing in the tree reads; removed for parity with the reference so the build's appended "PCIBus" is what the kernel sees.
Updates the affected reconstruction/divergences.md records (adding two that were missing table findings) so the earlier table-vs-reference comparisons are corrected to account for the build's append.

Test plan

Modelled each affected table's build output (source + the build's appended lines) and diffed it against Apple's shipped reference table where one exists; confirmed the duplicate is gone and no other content changed.
git diff restricted to only "Server Name" line removals in every touched .table file; no other lines altered.
Not rebuilt on the QEMU guest.

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/RhapsodiOS/RhapsodiOS/pull/29 **Author:** [@raynorpat](https://github.com/raynorpat) **Created:** 9/25/2026 **Status:** ✅ Merged **Merged:** 9/25/2026 **Merged by:** [@raynorpat](https://github.com/raynorpat) **Base:** `master` ← **Head:** `claude/competent-pare-e06a24` --- ### 📝 Commits (2) - [`f529759`](https://github.com/RhapsodiOS/RhapsodiOS/commit/f529759b18aae8cabb4ba04ef5a0ef9072103c3a) drivers: drop the "Server Name" line the build already appends from 39 Default.tables - [`e6fbf72`](https://github.com/RhapsodiOS/RhapsodiOS/commit/e6fbf7267f7a03e6ae5ce2fb9b7b3904ccbbdb12) drivers: drop the append-duplicated "Server Name" line from 36 more tables ### 📊 Changes **94 files changed** (+323 additions, -77 deletions) <details> <summary>View changed files</summary> 📝 `src/drivers-i386/bus/Intel82365PCMCIA/PCIC.drvproj/Default.table` (+0 -1) 📝 `src/drivers-i386/bus/Intel82365PCMCIA/PCIC.drvproj/PCI.table` (+0 -1) 📝 `src/drivers-i386/bus/Intel82365PCMCIA/reconstruction/divergences.md` (+21 -0) 📝 `src/drivers-i386/bus/Intel824X0PCI/Intel824X0.drvproj/Default.table` (+0 -2) 📝 `src/drivers-i386/bus/Intel824X0PCI/reconstruction/divergences.md` (+20 -0) 📝 `src/drivers-i386/bus/drvEISABus/EISABus.drvproj/Default.table` (+0 -1) 📝 `src/drivers-i386/bus/drvPCIBus/PCIBus.drvproj/Default.table` (+0 -1) 📝 `src/drivers-i386/bus/drvPCIBus/reconstruction/divergences.md` (+22 -0) 📝 `src/drivers-i386/bus/drvPCMCIABus/PCMCIABus.drvproj/Default.table` (+0 -1) 📝 `src/drivers-i386/ide/drvAHCI/AHCI.drvproj/Default.table` (+0 -1) 📝 `src/drivers-i386/ide/drvEIDE/EIDE.drvproj/Default.table` (+0 -1) 📝 `src/drivers-i386/ide/drvEIDE/EIDE.drvproj/Dual_EIDE.table` (+0 -1) 📝 `src/drivers-i386/ide/drvEIDE/EIDE.drvproj/EIDE_PIIX.table` (+0 -1) 📝 `src/drivers-i386/ide/drvEIDE/EIDE.drvproj/PnP_EIDE.table` (+0 -1) 📝 `src/drivers-i386/ide/drvPCFloppy/Floppy.drvproj/Default.table` (+0 -1) 📝 `src/drivers-i386/ide/drvPCFloppy/reconstruction/divergences.md` (+13 -0) 📝 `src/drivers-i386/input/drvBusMouse/BusMouse.drvproj/Default.table` (+0 -1) 📝 `src/drivers-i386/input/drvBusMouse/reconstruction/divergences.md` (+12 -0) 📝 `src/drivers-i386/input/drvISASerialPort/ISASerialPort.drvproj/Default.table` (+0 -1) 📝 `src/drivers-i386/input/drvISASerialPort/reconstruction/divergences.md` (+12 -0) _...and 74 more files_ </details> ### 📄 Description ## Summary - The driver build's `post_copy_tables` rule appends `"Server Name" = "$(NAME)";` to every table it copies into the built bundle, so a source table carrying its own `"Server Name"` line gets it twice in the built product. - Removes that duplicate line from 75 tables across `drivers-i386`, `drivers-ppc`, `drvPortServer`, and `drvSCSIServer` (any `.table` file actually listed in its project's `GLOBAL_RESOURCES`), leaving tables whose value differs from `NAME` untouched and noted. - `EIDE`, `Intel824X0`, `SerialPointingDevice`, and `CirrusLogicGD5434` also had Apple's own table carrying the line twice; the extra copy is removed as a labelled divergence from the reference. - `PCIBus`'s `Default.table` carried `"Server Name" = "BUS"`, which nothing in the tree reads; removed for parity with the reference so the build's appended `"PCIBus"` is what the kernel sees. - Updates the affected `reconstruction/divergences.md` records (adding two that were missing table findings) so the earlier table-vs-reference comparisons are corrected to account for the build's append. ## Test plan - Modelled each affected table's build output (source + the build's appended lines) and diffed it against Apple's shipped reference table where one exists; confirmed the duplicate is gone and no other content changed. - `git diff` restricted to only `"Server Name"` line removals in every touched `.table` file; no other lines altered. - Not rebuilt on the QEMU guest. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-11-03 22:04:29 -07:00