mirror of
https://github.com/RhapsodiOS/RhapsodiOS.git
synced 2026-11-03 22:01:40 -07:00
[GH-ISSUE #48] drvCirrusLogicGD5434: install fails in movehelp because the help folder is named Help, not DriverHelp #41
Labels
No labels
bug
documentation
enhancement
enhancement
good first issue
help wanted
help wanted
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
github-starred/RhapsodiOS#41
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @raynorpat on GitHub (Oct 14, 2026).
Original GitHub issue: https://github.com/RhapsodiOS/RhapsodiOS/issues/48
rbuild buildpackageofsrc/drivers-i386/video/drvCirrusLogicGD5434fails at install time, after the driver compiles and links:Cause.
driverTools-1/DriverProjectType/driver.makesetsSOURCE_HELP_DIR = DriverHelpandHELP_FILE = Help(lines 70–71). Itsmovehelprule (line 126) renames each language'sDriverHelptoHelpin the installed bundle. The Cirrus project ships its help already namedHelp, atCirrusLogicGD5434.drvproj/English.lproj/Help(CL_GD5434.rtfd,CL_GD5446.rtfd,TableOfContents.rtf). So there is noDriverHelpto move, and the rule's unconditionalmvfails.Most driver projects (33 under
src/drivers-i386) shipEnglish.lproj/DriverHelp.drvSB8SoundoverridesSOURCE_HELP_DIRin itsMakefile.preambleinstead.Possible fixes:
English.lproj/HelptoEnglish.lproj/DriverHelpin the project (and inPB.projectif it lists the resource); orSOURCE_HELP_DIR = Helpin the project'sMakefile.preamble, as drvSB8Sound does.Context. Seen on 2026-10-14 while rebuilding drivers on the i386 build guest (
rhap-i386-bootstrapped-v2.img, rbuild with--toolchain gcc-darwin-i386.conf --arch i386), on branchi386-flat. That branch's only change to this project is one config-table key, which is not involved here; the help layout is the same on master. The compile andkl_ldsteps succeed, so the driver binary itself is fine.@raynorpat commented on GitHub (Oct 14, 2026):
Fixed in
1d3b04e40on master: the Cirrus GD5434 help folder is nowEnglish.lproj/DriverHelp(with itsLOCAL_RESOURCESentry updated), matching the other i386 drivers, and SB8's redundantmovehelppreamble line is removed. The defaultmovehelpstep indriver.make.preamblenow handles both. Verified by reading the rule, not by a build.