github-starred/MonitorControl
2
0
Fork 0
mirror of https://github.com/MonitorControl/MonitorControl.git synced 2026-05-25 22:01:10 -06:00
Code Issues 21 Projects Packages Wiki Activity Actions

fix(Intel): hacky workaround for ddc unreliability

Browse source 
Requires a proper fix in the future, see:
#478
This commit is contained in:
JoniVR 2021-08-03 20:26:26 +02:00
parent 4f99be000a
commit 09e5e2a248
No known key found for this signature in database
GPG key ID: 3C8F6B8A7809ACDA
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
MonitorControl/Model/ExternalDisplay.swift
View file

@ -286,8 +286,13 @@ class ExternalDisplay: Display {
return self.arm64ddcComm(send: &send, reply: &reply)
#else
return self.ddc?.write(command: command, value: value, errorRecoveryWaitTime: 2000)
// NOTE: Loop is a hacky workaround that should probably be removed as it wasn't necessary before and makes things choppy.
// SEE: https://github.com/MonitorControl/MonitorControl/issues/478
var success = false
for _ in 1 ... 2 {
success = self.ddc?.write(command: command, value: value, errorRecoveryWaitTime: 2000) ?? false
}
return success
#endif
}